Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes that type/feature mappings are not available during setup #16324

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

gvkries
Copy link
Contributor

@gvkries gvkries commented Jun 14, 2024

This reverts some of the changes made by #15793. Especially, the population of the ITypeFeatureProvider was completley moved into the ShellContainerFactory. But this is too late e.g. for the CompositionStrategy which already requires some types being populated.

So I've moved that part back to the ExtensionManager, where it originally was done before #15793. This does not change the new behavior of having multiple features per type or the automatic detection of the feature without the FeatureAttribute, but the split responsibility of adding types to the ITypeFeatureProvider is now back.

Fixes #16289

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but I'm out of my depth here so would defer to others.

This indeed fixed the symptoms of #16289. What exactly in the changes fixes that BTW? What got stuck in App_Data after not running the setup?

@OrchardCMS OrchardCMS deleted a comment from hishamco Jun 27, 2024
@OrchardCMS OrchardCMS deleted a comment from hishamco Jun 27, 2024
@OrchardCMS OrchardCMS deleted a comment from hishamco Jun 27, 2024
@Piedone Piedone merged commit ba5e8c0 into OrchardCMS:main Jun 27, 2024
10 checks passed
@gvkries gvkries deleted the gvkries/setup-dependencies-16289 branch June 28, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrchardCoreCmsWeb Only runs one time, second run giving page not found error
4 participants