Fixes that type/feature mappings are not available during setup #16324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts some of the changes made by #15793. Especially, the population of the
ITypeFeatureProvider
was completley moved into theShellContainerFactory
. But this is too late e.g. for theCompositionStrategy
which already requires some types being populated.So I've moved that part back to the
ExtensionManager
, where it originally was done before #15793. This does not change the new behavior of having multiple features per type or the automatic detection of the feature without theFeatureAttribute
, but the split responsibility of adding types to theITypeFeatureProvider
is now back.Fixes #16289