New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddOrchardCms overload with a configure action. #2005
Conversation
I reverted the change that was not necessary. |
@@ -7,6 +7,7 @@ | |||
<TieredCompilation>true</TieredCompilation> | |||
<PreserveCompilationContext>true</PreserveCompilationContext> | |||
<MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish> | |||
<MvcRazorExcludeRefAssembliesFromPublish>false</MvcRazorExcludeRefAssembliesFromPublish> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
…f the old precompilation tool.
…ews) even if precompiled.
Otherwise this PR is ready. |
Here i also suggest to re-introduce this line in
OC.Cms.Web.csproj
so that it fixes #1156.Normally we don't need it but if a module didn't use the
Sdk.Razor
and / or forgot a direct reference toMicrosoft.AspNetCore.Mvc
, its views are not precompiled and then this line is needed. This because its views will be compiled at runtime, so therefs
folder with compilation libraries needs to be generated when publishing the application. So, let me know.