Make lists sortable with ordering setting #3711

deanmarcussen · 2019-05-27T14:30:11Z

This fixes #2355

Ordering is optional and configured on the last part settings

When enabled list items are sortable, when disabled they remain sorted by created date - descending

…ttings

…rent page#

… order now correctly updated on create

…date readme

Skrypt · 2019-05-27T18:25:46Z

I'm confused, I'm trying to find the Vue.js component but it seems it's initialized with JQuery?

deanmarcussen · 2019-05-27T19:11:28Z

I'm confused, I'm trying to find the Vue.js component but it seems it's initialized with JQuery?

Yes, I looked at the AdminMenu as you suggested, but that was done with jQuery nested sortable.
I did consider it being a Vue component, but did it this way as it meant all the js and markup could be left out of the page if ordering was disabled (as it is by default).

Figured a vue component would really suit for the other part of your notes on #2355 regarding adding existing items and detaching from #3667.

Happy to reconsider if you prefer it being done with Vue?

Skrypt · 2019-05-27T20:06:40Z

If the feature you are adding works it's fine merging it. I'm just surprised to see it's using JQuery instead of a full Vue.js component, but like you say it can be added later on. Up to you to do the changes on this PR or on an other one later on.

deanmarcussen · 2019-05-28T11:08:19Z

Probably another PR for the other features - not totally sure how add / move / detach items would work / look like yet

# Conflicts: # src/OrchardCore.Modules/OrchardCore.Lists/OrchardCore.Lists.csproj # src/OrchardCore.Modules/OrchardCore.Lists/Settings/ListPartSettingsDisplayDriver.cs # src/OrchardCore.Modules/OrchardCore.Lists/Startup.cs

deanmarcussen · 2019-10-08T16:04:56Z

@Skrypt @sebastienros Fixed up some merge conflicts on this old PR.

Is it wanted?

Skrypt · 2019-10-08T16:37:13Z

Sure it is 😄
I'm just busy 😢

agriffard · 2019-12-02T13:07:14Z

Conflicts due to Docs and Fielsets PRs that have been merged recently.
Please solve them @deanmarcussen

agriffard · 2019-12-15T11:07:48Z

Please solve conflicts @deanmarcussen

# Conflicts: # src/OrchardCore.Modules/OrchardCore.Contents/Views/Content.SummaryAdmin.cshtml # src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartSettings.Edit.cshtml

deanmarcussen · 2019-12-15T12:23:15Z

@agriffard conflicts resolved. tested as it's so old this pr, but still works fine!

Skrypt · 2019-12-15T21:11:59Z

Ok reviewing this one now.

Skrypt · 2019-12-15T21:33:44Z

It's still using netstandard 2.0 so we can't merge this.

deanmarcussen · 2019-12-16T08:02:26Z

It's still using netstandard 2.0 so we can't merge this.

@Skrypt how do you figure that?

Here's the complete .csproj from that branch. On core3 as far as I can see... (note did just re sort project references)

<Project Sdk="Microsoft.NET.Sdk.Razor">

  <PropertyGroup>
    <TargetFramework>$(AspNetCoreTargetFramework)</TargetFramework>
    <AddRazorSupportForMvc>true</AddRazorSupportForMvc>
  </PropertyGroup>

  <ItemGroup>
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.Admin.Abstractions\OrchardCore.Admin.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.AdminMenu.Abstractions\OrchardCore.AdminMenu.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentLocalization.Abstractions\OrchardCore.ContentLocalization.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentManagement.Abstractions\OrchardCore.ContentManagement.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentManagement.Display\OrchardCore.ContentManagement.Display.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentTypes.Abstractions\OrchardCore.ContentTypes.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.Media.Abstractions\OrchardCore.Media.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.MetaWeblog.Abstractions\OrchardCore.MetaWeblog.Abstractions.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.Module.Targets\OrchardCore.Module.Targets.csproj" />
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.Users.Abstractions\OrchardCore.Users.Abstractions.csproj" />   
    <ProjectReference Include="..\..\OrchardCore\OrchardCore.ResourceManagement.Abstractions\OrchardCore.ResourceManagement.Abstractions.csproj" />
    <ProjectReference Include="..\OrchardCore.Contents\OrchardCore.Contents.csproj" />
  </ItemGroup>

</Project>

Skrypt · 2019-12-16T08:35:23Z

I think I know what I did wrong then

Skrypt · 2019-12-16T10:28:05Z

I made some small css fixes but I can't push to your fork.

Skrypt · 2019-12-16T21:35:49Z

Ok it worked. The commits are pushed. I think it can be merged now.

deanmarcussen · 2019-12-17T07:42:50Z

cheers @Skrypt changes LGTM. @agriffard if you feel like merging :)

agriffard · 2019-12-17T08:48:40Z

@deanmarcussen What about a démo in today's meeting?

deanmarcussen · 2019-12-17T08:59:26Z

Why not indeed Antoine :)

# Conflicts: # src/OrchardCore.Modules/OrchardCore.Lists/Settings/ListPartSettingsDisplayDriver.cs

Skrypt · 2020-01-28T20:06:00Z

src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs

@@ -72,29 +59,22 @@ public override IDisplayResult Display(ListPart listPart, BuildPartDisplayContex
                );
        }

-        private async Task<PagerSlim> GetPagerAsync(IUpdateModel updater, ListPart part)
+        private async Task<PagerSlim> GetPagerAsync(BuildPartDisplayContext context)


It should be GetPagerSlimAsync and we should also have GetPagerAsync

It should be GetPagerSlimAsync and we should also have GetPagerAsync

Changed to GetPagerSlimAsync.
What did you mean by also having GetPagerAsync? As a settings option too have the other type of pager?

deanmarcussen added 6 commits May 24, 2019 12:14

Added enable ordering settings to listpart

a61a1f8

actually setting is better as a bool, as we have no contained part se…

2dcaa05

…ttings

displaying a sort handle

de814f5

wip starting to get an ordering concept working. need to know the cur…

33eb1ef

…rent page#

sortable lists, resolved container service to do most of the lifting,…

d6cbca6

… order now correctly updated on create

restrict containerservice to only update orders that have changed. up…

40c88c1

…date readme

Skrypt self-requested a review July 10, 2019 18:31

deanmarcussen added 2 commits October 8, 2019 16:59

Merge branch 'dev' into lists-sortable

d80f760

# Conflicts: # src/OrchardCore.Modules/OrchardCore.Lists/OrchardCore.Lists.csproj # src/OrchardCore.Modules/OrchardCore.Lists/Settings/ListPartSettingsDisplayDriver.cs # src/OrchardCore.Modules/OrchardCore.Lists/Startup.cs

Fix after merge conflict

2a27aaa

Merge branch 'dev' into lists-sortable

f4ac1e7

# Conflicts: # src/OrchardCore.Modules/OrchardCore.Contents/Views/Content.SummaryAdmin.cshtml # src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartSettings.Edit.cshtml

agriffard requested review from Skrypt and removed request for Skrypt December 15, 2019 14:31

Resort Project References

2f4de3c

Skrypt added 3 commits December 16, 2019 05:14

Some CSS adjustments

df55d48

Removing space

7e66bcf

Small UI fixes

bb9e18a

deanmarcussen and others added 5 commits January 26, 2020 08:53

Update list ordering to support drafts and cloning

6ee2849

Merge branch 'dev' into lists-sortable

4dfa257

# Conflicts: # src/OrchardCore.Modules/OrchardCore.Lists/Settings/ListPartSettingsDisplayDriver.cs

Merge branch 'dev' into lists-sortable

3ee1914

use sortablejs from registered resources

e108a29

tidy up list part driver

27fb0cc

Skrypt reviewed Jan 28, 2020

View reviewed changes

GetPager to GetPagerSlim

5c0c1bb

deanmarcussen merged commit 0d46fef into OrchardCMS:dev Jan 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make lists sortable with ordering setting #3711

Make lists sortable with ordering setting #3711

deanmarcussen commented May 27, 2019

Skrypt commented May 27, 2019

deanmarcussen commented May 27, 2019

Skrypt commented May 27, 2019

deanmarcussen commented May 28, 2019

deanmarcussen commented Oct 8, 2019

Skrypt commented Oct 8, 2019

agriffard commented Dec 2, 2019

agriffard commented Dec 15, 2019

deanmarcussen commented Dec 15, 2019

Skrypt commented Dec 15, 2019

Skrypt commented Dec 15, 2019

deanmarcussen commented Dec 16, 2019

Skrypt commented Dec 16, 2019

Skrypt commented Dec 16, 2019 •

edited

Skrypt commented Dec 16, 2019

deanmarcussen commented Dec 17, 2019

agriffard commented Dec 17, 2019

deanmarcussen commented Dec 17, 2019

Skrypt Jan 28, 2020 •

edited

deanmarcussen Jan 29, 2020

Make lists sortable with ordering setting #3711

Make lists sortable with ordering setting #3711

Conversation

deanmarcussen commented May 27, 2019

Skrypt commented May 27, 2019

deanmarcussen commented May 27, 2019

Skrypt commented May 27, 2019

deanmarcussen commented May 28, 2019

deanmarcussen commented Oct 8, 2019

Skrypt commented Oct 8, 2019

agriffard commented Dec 2, 2019

agriffard commented Dec 15, 2019

deanmarcussen commented Dec 15, 2019

Skrypt commented Dec 15, 2019

Skrypt commented Dec 15, 2019

deanmarcussen commented Dec 16, 2019

Skrypt commented Dec 16, 2019

Skrypt commented Dec 16, 2019 • edited

Skrypt commented Dec 16, 2019

deanmarcussen commented Dec 17, 2019

agriffard commented Dec 17, 2019

deanmarcussen commented Dec 17, 2019

Skrypt Jan 28, 2020 • edited

Choose a reason for hiding this comment

deanmarcussen Jan 29, 2020

Choose a reason for hiding this comment

Skrypt commented Dec 16, 2019 •

edited

Skrypt Jan 28, 2020 •

edited