Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZoneOnDemand.AddAsync(). #3864

Merged
merged 1 commit into from Jul 11, 2019
Merged

ZoneOnDemand.AddAsync(). #3864

merged 1 commit into from Jul 11, 2019

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Jun 27, 2019

The overlaoded Shape.Add() in ZoneOnDemand do the following

dynamic zone = _zoneFactory().GetAwaiter().GetResult();

So here i added and used an async version that do

dynamic zone = await _zoneFactory();

Maybe related to #3860 where it seems that the dyn layout is not well built, e.g without a Zones prop.

@jtkech
Copy link
Member Author

jtkech commented Jul 4, 2019

@sebastienros

Maybe this one is interesting for perf because here, when we add a zone, we prevent its factory, that may do session queries, to run synchronously, e.g through the layer filter.

If it will be merged, i will integrate it in 3.0 for benchmark testing.

@Skrypt Skrypt self-requested a review July 10, 2019 18:28
@Skrypt Skrypt merged commit ed21129 into dev Jul 11, 2019
@jtkech jtkech deleted the jtkech/zoneOnDemand branch August 21, 2019 06:19
scleaver pushed a commit to scleaver/OrchardCore that referenced this pull request Aug 22, 2019
MatthijsKrempel pushed a commit to MatthijsKrempel/OrchardCore that referenced this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants