Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization files publishing #4088

Merged
merged 8 commits into from Aug 28, 2019
Merged

Localization files publishing #4088

merged 8 commits into from Aug 28, 2019

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Aug 23, 2019

Prevents localization files from being outputed under the bin folder on building.

Just output them on publishing.

And other tweaks.

Update: Do we want to publish wwwroot/is-cache? Let me know.

@hishamco
Copy link
Member

LGTM

</ItemGroup>

<ItemGroup>
<ResolvedFileToPublish Include="App_Data\**" Exclude="App_Data\**\*.log">
<RelativePath>App_Data\%(RecursiveDir)%(Filename)%(Extension)</RelativePath>
</ResolvedFileToPublish>

<ResolvedFileToPublish Include="Localization\**" Exclude="Localization\is-cache\**">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this Exclude="Localization\is-cache\**

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry i'm too tired, i will fix it

@jtkech jtkech mentioned this pull request Aug 25, 2019
@jptissot
Copy link
Member

Looks good!

@jtkech
Copy link
Member Author

jtkech commented Aug 25, 2019

Thanks, the pattern for the images cache will need to be updated when #4025 from @deanmarcussen will be merged.

@sebastienros sebastienros merged commit ebcde84 into dev Aug 28, 2019
@sebastienros sebastienros deleted the jtkech/localization branch August 28, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants