remove injection of expressionEvaluator in class #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ExpressionEvaluator from the base class
hishamco
requested changes
Aug 17, 2020
| @@ -19,14 +19,11 @@ public class SetupTenantTask : TenantTask | |||
| { | |||
| private readonly IClock _clock; | |||
| private readonly IUpdateModelAccessor _updateModelAccessor; | |||
| private readonly IWorkflowExpressionEvaluator _expressionEvaluator; | |||
|
|
|||
| public SetupTenantTask(IShellSettingsManager shellSettingsManager, IShellHost shellHost, ISetupService setupService, IClock clock, IWorkflowExpressionEvaluator expressionEvaluator, IWorkflowScriptEvaluator scriptEvaluator, IUpdateModelAccessor updateModelAccessor, IStringLocalizer<SetupTenantTask> localizer) | |||
There was a problem hiding this comment.
Also remove theexpressionEvaluator from the constructor
There was a problem hiding this comment.
cant remove , because thats how its passed to the base class.
There was a problem hiding this comment.
Oops I forgot that, just remove my comment
deanmarcussen
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ExpressionEvaluator from the base class