Popups don't work on Chrome 90

[neexite]

No description provided.

[neexite]

We are working on a prototype to fix it
Prototype V1:
Composite.Hotfixes.Hotfix769.zip

[VolodymyrMuzyka]

@neexite v1 prototype fixing the context menu issue, at same time when you trying to edit the page (using context menu or top menu) - its keep loading.. so u are not able to edit. Without patch - editing working when accessed using top menu.

[paschneider]

@neexite
Same here. Chrome Version 90.0.4430.72 (64-Bit).
All buttons in EditView not clickable. Thanks for working on a fix!

[neexite]

RC1 version for C1 6.2+
Composite.Hotfixes.Hotfix769.zip

[burningice2866]

is there any change to review the code changes in a dedicated branch?

[neexite]

@burningice2866 For now, we made a fix only for multiple versions of C1 as a separate package.
Source available https://github.com/Orckestra/CMS-Packages/tree/hotfixes/769-popup-chrome-issue/Composite.Hotfixes.Hotfix769
Basically. we just rename ui:popup to ui:plainpopup element on fly.

https://support.google.com/chrome/thread/106244569?hl=en

[napernik]

We will make a proper fix for the next release of C1 (renaming the html tag).

A package with a hotfix is available from the console:

After installing the package, it is necessary to restart the C1 console.

For the automated deployments, the following line can be added to SetupDescription.xml:

<package id="d3e8772f-6f48-4933-805e-d822e10c2e2a" url="https://package.composite.net/Download.ashx?package=Composite.Hotfixes.Hotfix769&amp;c1version=$(version)"/>

[burningice2866]

@burningice2866 For now, we made a fix only for multiple versions of C1 as a separate package.
Source available https://github.com/Orckestra/CMS-Packages/tree/hotfixes/769-popup-chrome-issue/Composite.Hotfixes.Hotfix769

Thank you for sharing. Its the best way to learn more about the inner workings of the CMS.

[Pixelfeeeee]

Same problem with Composite C1 Version 4.3, but the Hotfix update is not available there.
Any chance to get it for older versions?

[neexite]

@Pixelfee

1. You can try download RC1(few post early or public version, or build from source code), unpack, change minimumCompositeVersion to 4.3.0.0 in "install.xml", pack to zip archive, and try to install.
2. You can try to install manually: there are few files and one line in file "web.config"

[paschneider]

@neexite We tried installing it manually for C1 4.3 - Registering the http module an all neccesary js / css files.
Contextmenu now opens in main tree. But the tinymce page editor isn't loading anymore :(

No js errros on console found.
If we disable the output transformation editor is opening againg, but no menu clickable ;-)

Maybe something incompatible with the "old" tiny mce?

[neexite]

@paschneider

1. Could you check that /Composite/content/misc/editors/visualeditor/visualeditor.aspx contains closed tags <script> </script> (not <script />) in a browser,
2. Could you try add modification to the ~/Composite/transformations/defaultfilters/masterfilter.xsl instead register new oupupt transformation(769.xsl).
   

[paschneider]

@neexite Looks good!
Adding the xsl transforamtion to ~/Composite/transformations/defaultfilters/masterfilter.xsl helped!
I added the two blocks at the end before the closing "</xsl:stylesheet>" tag.

In the /Composite/content/misc/editors/visualeditor/visualeditor.aspx file are all tags closed (<script> </script>)

Do you think there will be a hotfix-package for the old 4.3 systems soon? Otherwise we will script it by our self ;-)

[dabitbol]

Unfortunately we will not issue a fix for 4.3 as this version is not supported anymore. You are more than welcome to submit a PR though. Thanks for understanding.

[jlu344]

Hello,
Im having an issue with the Hotfix769. After installation the console ui looks messed up. Hidden menus are now visible and the popup menus are not visible when we right clicking on menu tree. Is this happening to anyone else? We deployed the fix to both dev and qa environments and we have the same issue in both envs. Our C1 version is the most current. 6.10

[burningice2866]

Hello,
Im having an issue with the Hotfix769. After installation the console ui looks messed up. Hidden menus are now visible and the popup menus are not visible when we right clicking on menu tree. Is this happening to anyone else? We deployed the fix to both dev and qa environments and we have the same issue in both envs. Our C1 version is the most current. 6.10

Can't say i have experienced this. Have installed the hotfix on a number of sites now ranging from version 6.2 to 6.10 and haven't had any issues.

[rmzeck]

Hello,
Im having an issue with the Hotfix769. After installation the console ui looks messed up. Hidden menus are now visible and the popup menus are not visible when we right clicking on menu tree. Is this happening to anyone else? We deployed the fix to both dev and qa environments and we have the same issue in both envs. Our C1 version is the most current. 6.10

Can't say i have experienced this. Have installed the hotfix on a number of sites now ranging from version 6.2 to 6.10 and haven't had any issues.

This happens when installing the hotfix on a site setup as a child application under root. This results in a broken path of the files in the following directory:
\Composite\InstalledPackages\hotfixes\769
I've had luck just moving these files to where they're expected to be. You should be able to inspect your page and see exactly where that is.

[RobertJ1985]

Hi. After updating to this hotfix i'm not able to create any new datatypes or editing existing ones. It complains about reference.

[wwwysocki]

@neexite Retested v.6.10 in Crome v. 95*. works OK, popups pop up as expected. I suggest we close the bug?