Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing 24 #30

Merged
merged 5 commits into from Jan 12, 2017
Merged

Conversation

binduwavell
Copy link
Contributor

A first attempt to write up our contribution policies and processes. Please review and provide feedback so we can solidify this stuff before our 1.0.0 milestone.

resolves #24

@binduwavell
Copy link
Contributor Author

@AFaust I have called out a few places that particularly could do with some input from you.

@AFaust
Copy link
Contributor

AFaust commented Jan 9, 2017

That is actually the first time I pushed to someone else's fork as part of a PR review. Note that the 4th link to a .jshintrc is currently pointing nowhere. I just realized that the site-webscript structure on the Share-tier needs a bit of consoldiation to match the same base package used on the Repository-tier, and the link points to where the .jshintrc would be found after that consolidation..

Copy link
Contributor

@AFaust AFaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine top merge as it is now.

@binduwavell binduwavell merged commit 34974c6 into OrderOfTheBee:master Jan 12, 2017
@binduwavell binduwavell deleted the contributing-24 branch January 17, 2017 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contribution guidelines for the project
2 participants