Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wicket-orientdb as a git submodule #133

Closed
krichter722 opened this issue Mar 8, 2015 · 6 comments
Closed

Add wicket-orientdb as a git submodule #133

krichter722 opened this issue Mar 8, 2015 · 6 comments

Comments

@krichter722
Copy link
Contributor

This wouldn't interfere with the development of wicket-orientdb as a separate project, but due to the fact that the projects are quite close a specific revision could be enforced if it is necessary for a patch in Orienteer which is not provided by the maven versioning schema x.y.z or x.y.z-SNAPSHOT.

@PhantomYdn
Copy link
Member

I'm not so familiar with git feature for submodules. Thanks! I'll take a look.

@krichter722
Copy link
Contributor Author

If you're ok with it I can do it. Assign me and I'll get started.

@PhantomYdn
Copy link
Member

Can it be delivered as PR? If yes - yes please - I will check it out.

Will it be possible, for example: make changes in this submodule and than commit them to your own wicket-orientdb clone?

@krichter722
Copy link
Contributor Author

That is precisely the idea behind submodules. They serve to enforce a certain state of the submodule which is used for the build in the project. This state is managed in the parent git. You can commit in the submodule and no one will ever know it has be done in a submodule rather than in an independent clone, because there's no reason to distinguish.

@PhantomYdn
Copy link
Member

I see the reason... lets return to this after releasing of 1.0. While wicket-orientdb and Orienteer are being developed in parallel: imho it might slow down turn around.

@PhantomYdn
Copy link
Member

git feature was checked. It's not for now. Issue might be reopened if some real-life cases occur.

@PhantomYdn PhantomYdn modified the milestones: v1.2, v1.1 Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants