Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added submodules update command to be executed in maven's intialize phase #152

Closed
wants to merge 6 commits into from
Closed

Conversation

krichter722
Copy link
Contributor

This should fix #133, merge whenever you're ready, e.g. after 1.0 has been released.

@krichter722
Copy link
Contributor Author

The travis build fails because the build server can't checkout with SSH URL git@github.com:PhantomYdn/wicket-orientdb.git. This is no issue for a normal user, right? Correct to HTTPS URL or reconfigure travis (possible?)?

@PhantomYdn
Copy link
Member

Hmm... Hopefully yes - you are right...

@krichter722
Copy link
Contributor Author

@PhantomYdn
Copy link
Member

Thanks for the question. Will follow.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.04% when pulling 0ea2e20 on krichter722:submodules1 into 199cf7b on PhantomYdn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.04% when pulling 7637703 on krichter722:submodules1 into 199cf7b on PhantomYdn:master.

@krichter722
Copy link
Contributor Author

Work in my fork (see https://travis-ci.org/krichter722/Orienteer/builds/56506169 for details). Can you restart travis, please (it's not the sharpest guy around when it comes to recognizing repository updates...).

@PhantomYdn
Copy link
Member

I guess that's because of some merge problem. You can fix that yourself by merging of upstream/master.
In any case I want to spent some time on this git feature before accepting PR...

Btw, can you please share with me why are you interested in Orienteer? Might be I can review priorities in development and so on.

@krichter722
Copy link
Contributor Author

I guess that's because of some merge problem. You can fix that yourself by merging of upstream/master.
In any case I want to spent some time on this git feature before accepting PR...

I fixed issues in 7637703, but travis-ci runs build with 16068bf (see https://travis-ci.org/PhantomYdn/Orienteer/builds/56506333 and https://travis-ci.org/krichter722/Orienteer).

Btw, can you please share with me why are you interested in Orienteer? Might be I can review priorities in development and so on.

The offer is appreciated, but I can't make any prognose about my future capabilites to contribute (and the current were not that severe imo). I think orientdb is great, but the web frontend ("studio") doesn't progress very much for the feature I'm missing, so I was happy to find an alternative written in Java and wanted to support it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 66.25% when pulling e7903ac on krichter722:submodules1 into 199cf7b on PhantomYdn:master.

@krichter722
Copy link
Contributor Author

I finally figured it out :) Take the time to get started with submodules. I messed up badly before the last commit, but with the current project structure it just make a lot of sense to use such.

The test coverage increase doesn't mean anything IMO because there're no functional changes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.29%) to 66.33% when pulling fe29639 on krichter722:submodules1 into 199cf7b on PhantomYdn:master.

@PhantomYdn
Copy link
Member

git feature was checked. It's not for now. Issue might be reopened if some real-life cases occur.

@PhantomYdn PhantomYdn closed this Jul 17, 2015
@krichter722 krichter722 deleted the submodules1 branch January 11, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wicket-orientdb as a git submodule
3 participants