Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Attestations: Email/Phone/Facebook/Twitter #13

Closed

Conversation

tyleryasaka
Copy link
Contributor

@tyleryasaka tyleryasaka commented Apr 10, 2018

(1) This updates the phone verification to return an actual signature for the attestation. The signature is compatible with the current implementation of ERC725 that we're using.

(2) Adds email verification using Sendgrid

(3) Adds Facebook & Twitter verification using Oauth

Finishes #22

@tyleryasaka tyleryasaka changed the title Return valid attestations Email/phone attestations Apr 11, 2018
@tyleryasaka tyleryasaka changed the title Email/phone attestations Email/Phone Attestations Apr 11, 2018
Returns an attestation if verification is successful
Currently Flask Session is using the filesystem to store session data.
Files are placed in `flask_session`. Eventually we probably want to
switch to Redis or something, but this should do for now.
@tyleryasaka tyleryasaka changed the title Email/Phone Attestations Attestations: Email/Phone/Facebook/Twitter Apr 13, 2018
@DanielVF
Copy link
Contributor

DanielVF commented Apr 13, 2018

A casual reading through code looks like this is a good start?

Do we need anything in the README telling you what API keys you'll need to get for a full setup?

@tyleryasaka
Copy link
Contributor Author

@DanielVF Yeah, we have dev.env which lists them, but that's probably not very helpful. Added a few lines to the readme that document the API keys being used.

Side note: I just noticed there is at least one python library for Twitter. Might be one for Facebook too. Somehow the documentation I was looking at linked me to some examples which I used to guide my implementation. Using twitter/facebook specific libraries would probably make the code cleaner, but I don't think it's worth sinking time into right now.

Also list it in readme under Sendgrid API keys
@DanielVF DanielVF removed their request for review April 17, 2018 12:58
@tyleryasaka
Copy link
Contributor Author

Closing in favor of #27. (Creating a new PR because this branch was created on my fork of the repo, before I had access to create branches.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants