Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OETH N 09 - Decimals #1516

Closed
wants to merge 1 commit into from
Closed

OETH N 09 - Decimals #1516

wants to merge 1 commit into from

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented May 18, 2023 •
edited

change decimal type to uint8

Important deploy considerations: (DON'T MERGE YET)

  • This changes VaultAdmin code in a way where existing decimals of supported assets will not be readable
  • when merging this in a deploy script should be created that:
    • updates the VaultAdmin
    • calls cacheDecimals on VaultAdmin for all of the currently supported assets of the Vault

** connected issue:** #1534

@rafaelugolini rafaelugolini temporarily deployed to preview-sparrowdom-oeth-qn6szy May 18, 2023 21:02 Inactive
@DanielVF DanielVF added contracts Works related to contracts hold labels May 19, 2023
@DanielVF DanielVF changed the title OETH N 09 OETH N 09 - Decimals May 22, 2023
@naddison36
Copy link
Collaborator

This has been fixed for the OETH Vault on the collateral swaps PR #1559

The OUSD Vault will need to be upgraded separately.

@naddison36
Copy link
Collaborator

Closing as this is being done in collateral swaps

@naddison36 naddison36 closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielVF DanielVF Awaiting requested review from DanielVF DanielVF will be requested when the pull request is marked ready for review DanielVF is a code owner

@naddison36 naddison36 Awaiting requested review from naddison36 naddison36 will be requested when the pull request is marked ready for review naddison36 is a code owner

@shahthepro shahthepro Awaiting requested review from shahthepro shahthepro will be requested when the pull request is marked ready for review shahthepro is a code owner

Assignees
No one assigned
Labels
contracts Works related to contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sparrowDom @naddison36 @DanielVF @rafaelugolini