Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H01 - safe approve all tokens #1776

Merged
merged 1 commit into from
Aug 30, 2023
Merged

H01 - safe approve all tokens #1776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 10 additions & 6 deletions contracts/contracts/strategies/balancer/BalancerMetaPoolStrategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,15 @@ contract BalancerMetaPoolStrategy is BaseAuraStrategy {
}

/**
* @notice Approves the Balancer pool to transfer all supported
* assets from this strategy.
* Also approve any suppered assets that are wrapped in the Balancer pool
* like stETH and frxETH, to be transferred from this strategy to their
* respective wrapper contracts. eg wstETH and sfrxETH.
* @notice Approves the Balancer Vault to transfer poolAsset counterparts
* of all of the supported assets from this strategy. E.g. stETH is a supported
* strategy and Balancer Vault gets unlimited approval to transfer wstETH.
*
* If Balancer pool uses a wrapped version of a supported asset then also approve
* unlimited usage of an asset to the contract responsible for wrapping.
*
* Approve unlimited spending by Balancer Vault and Aura reward pool of the
* pool BPT tokens.
*
* Is only executable by the Governor.
*/
Expand All @@ -434,7 +438,7 @@ contract BalancerMetaPoolStrategy is BaseAuraStrategy {
{
uint256 assetCount = assetsMapped.length;
for (uint256 i = 0; i < assetCount; ++i) {
_approveAsset(assetsMapped[i]);
_abstractSetPToken(assetsMapped[i], platformAddress);
}
_approveBase();
}
Expand Down