Exist _lock earlier if target lock balance is zero
#1975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add information on how to installed a fixed version of brownie * update docs
* make it possible for governor to enable rebasing. Add events to rebase opt in/out functions * prettier * AccountRebasingEnalbed/Disabled whenever appropriate
* add basic run script * intermediary commit * update the runlog * add documentation regarding strategist runs * Fix typo --------- Co-authored-by: Shahul Hameed <10547529+shahthepro@users.noreply.github.com>
* Upgrade OETH token * update description * prettier
* Shorten Dripper Duration * Fix bug * Lint --------- Co-authored-by: Shahul Hameed <10547529+shahthepro@users.noreply.github.com>
* Add script * split up runs --------- Co-authored-by: Shahul Hameed <10547529+shahthepro@users.noreply.github.com>
* Add script * split up runs * update names --------- Co-authored-by: Shahul Hameed <10547529+shahthepro@users.noreply.github.com>
* update migrations file of 83 deploy * update proposal id * prettier
* OETH jan24 reallocation * adjust tolerances
* Added Balancer deposit Update Convex AMO harvest Added Balancer harvest * Updated Convex AMO and Balancer harvests value flows Updated buyback value flows * Added vote locked CVX to buyback
naddison36
requested review from
sparrowDom,
DanielVF,
shahthepro,
smitch88 and
rafaelugolini
as code owners
5 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## nicka/convex-frax-locking #1975 +/- ##
=============================================================
- Coverage 73.96% 73.26% -0.71%
=============================================================
Files 61 61
Lines 3004 3015 +11
Branches 777 781 +4
=============================================================
- Hits 2222 2209 -13
- Misses 779 803 +24
Partials 3 3 ☔ View full report in Codecov by Sentry. |
…ar it is not used internally.
|
This PR has been replaced with #1976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Frax Convex Strategy from yAudit comments.
_lockfunction earlier if target and locked balances are both zerocheckBalance