Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

[RFC] Issue #36 - add approx price #118

Closed
wants to merge 73 commits into from
Closed

[RFC] Issue #36 - add approx price #118

wants to merge 73 commits into from

Conversation

inkredabull
Copy link
Contributor

@inkredabull inkredabull commented Apr 19, 2018

#36

@wanderingstan don't know if your culture is to entertain RFC/WIP PRs but here we go...

Checklist:

  • Testing (no other component tests??)
  • No docs to update

Description:

  • Adding approximate price to UI (ListingCard) using cryptocompare per original requirements
  • still need to:
    • add caching and/or update for Cryptonator
    • add test for rendered markup
    • ensure always two decimal places
    • incorporate bridge server if so desired (docs?)

Example:
screen shot 2018-04-19 at 12 12 05 pm

screen shot 2018-04-24 at 12 48 06 pm

@inkredabull
Copy link
Contributor Author

Ping @wanderingstan - would love to continue making progress just need a little guidance around what's really essential to get this into mergeable state.

@wanderingstan
Copy link
Collaborator

Hey @inkredabull just took a look. Looks like some merge conflicts came up due to other work on develop.

Important: Could you re-submit this as a PR against develop? (I don't think we had our PR messaging clear when you made this one.)

@inkredabull
Copy link
Contributor Author

Sure @wanderingstan - will rebase against develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants