Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Notifications Instructions #1213

Merged
merged 4 commits into from
Jan 21, 2019
Merged

Notifications Instructions #1213

merged 4 commits into from
Jan 21, 2019

Conversation

micahalcorn
Copy link
Member

For reference 📖

In origin-discovery...

- Run `node src/listener/listener.js --continue-file=continue --webhook=http://localhost:3456/events`

Copy link
Contributor

@Natasha08 Natasha08 Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahalcorn I have at least one undefined variable
image

I think it is the DATABASE_URL.

  • Is this the correct format postgresql://localhost/notification?
  • Is there another variable I need?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot one. Thanks for testing. 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Natasha08 try now with 37dd006 🤞

@Natasha08
Copy link
Contributor

Natasha08 commented Jan 10, 2019

@micahalcorn that seemed to work! So now on the DApp side, I'm seeing this in the console when I try to enable notifications. I don't see an error as a user, but I don't see notifications also

image

@micahalcorn
Copy link
Member Author

@Natasha08 have you taken some action that would trigger a notification? For example, subscribe to notifications from a seller account in browser A and then create an offer from a buyer account in browser B?

@Natasha08
Copy link
Contributor

@micahalcorn Yes I have been doing the example you mentioned. The origin notifications widget shows the notification, but after getting the browser window asking for permission to show notifications, I do not see browser notifications

@micahalcorn micahalcorn mentioned this pull request Jan 11, 2019
22 tasks
@Natasha08
Copy link
Contributor

Natasha08 commented Jan 17, 2019

@micahalcorn I finally have notifications working with these additions.

  1. node -v 10.13.0 -- turns out this was causing quite a few errors.

  2. I needed origin-messaging with this .env: (to create listings)

MESSAGING_NAMESPACE=dev

And npm start in origin-messaging.

  1. In origin-dapp/.env:
# for origin-messaging
MESSAGING_API_URL=http://localhost:6647
MESSAGING_NAMESPACE=dev
IPFS_SWARM=/ip4/138.86.157.230/tcp/9012/ws/ipfs/QmT14Wz5ZD9D4c1UQKBFV88eZK7MDBAFPBwTgxPgjLw7Fa

# for origin-notifications
NOTIFICATIONS_KEY=BKDF3aZ4qOYzocnnS7uQXZT8Po211PdOHGGwnOOUSLyybjtS7aU9yFlzInyO0YtKkwK3pdflHlfim4Eh4tkz35A
NOTIFICATIONS_URL=http://localhost:3456/
  1. In origin-discovery/.env ATTESTATION_ACCOUNT=0x99C03fBb0C995ff1160133A8bd210D0E77bCD101.

  2. Finally, for this error
    image I had to clear local storage

@micahalcorn micahalcorn merged commit 218bcfc into master Jan 21, 2019
@micahalcorn micahalcorn deleted the micah/notifications-readme branch January 21, 2019 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants