Issue #36 : add approx price

[inkredabull]

Checklist:

• No Tests
• No README change

Description:

• opted for least-effort inclusion of approximate price with Cryptonator API
• no tests; maybe someday?

Ref

• Add approximate price in USD (or EUR) #36
• Issue #36 - add approx price #130

[DanielVF]

Cool!

I'm wondering if it might look better formatted as "Approximately $6,041.79 USD". The parenthesis, tilde, and three digit cents add a lot of visual noise.

[inkredabull]

I agree with you in principle @DanielVF but what I thought would be a slam-dunk for a "good first issue" had me sink a bunch of time in the last three weeks around rebasing, conflict resolution, infra changes, and testing.

On the flip side, ABL ("Always Be Learning") ;-)

Didn't realize the project was changing so quickly when I joined; If there's consensus around the need for an improved UX beyond what it is now, can adjust but would love this to be merged as-is and will just figure on buffering more going forward.

[DanielVF]

Micah, maybe Aure could take a pass at how we want to display alternate prices, both on the search page, and the listing detail pages.

I changed this to use two decimal places.

[wanderingstan]

For reference, this is how MetaMask shows ETH/USD combinations:

Not that MetaMask is a great design inspiration, but it is what a lot of our users will see as the final price that they have to sign off on.

[DanielVF]

Here's another design:

[auregimon]

I like the first option @DanielVF

ETH and USD to the left of it, same font size and USD in lighter gray. Try putting a pipe | in between the two if it looks weird.

[DanielVF]

And here's the final design:

Note an important design change - we're now focusing on the fiat price first, with the ETH (or other crypto currency / token) taking a secondary visual weight.

[matthewliu]

aure and i somehow missed this issue and the discussion around it. this is not going to fly. the current UI is very misleading as the USD will constantly fluctuate. unless we are using a stablecoin, we need to price in a primary denomination that doesn't change values over time. the USD needs to have very clear "approximation" denoted.

[wanderingstan]

@matthewliu , am I correct in understanding that you would prefer (A) to have the eth/token price first, with approx dollar afterward (with dollar more clearly marked as appprox), or (B) take out dollars entirely, and potentially re-introduce dollars after more design thought?

[matthewliu]

A. I like the dollars but having it as primary is misleading because it would be changing minute-by-minute.