Use previewPoints on contract to compute APY
#390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shahthepro
commented
Jul 4, 2023
shahthepro
commented
- Gets the veOGVReceived from contract (Fixes Unexpected veOGV amount #342)
- Fixes under-reporting of APY calculation (Need someone to verify the APY)
smitch88
reviewed
Jul 5, 2023
| useEffect(() => { | ||
| if (!contracts.loaded) return; | ||
|
|
||
| let done = false; |
There was a problem hiding this comment.
Not familiar with this pattern for how you are using done, what are you trying to solve? Just running the go function once?
There was a problem hiding this comment.
Just defensive programming. go is an async function. It's possible that the component might rerender before the function completes execution. If it does, then setState will throw a bunch of console errors because it's trying to update state of a detached component. When the component demounts, done is set to true and the state isn't updated in that case
sparrowDom
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.