Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance walletconnect v2, geofencing modal, and style fixes #402

Merged
merged 10 commits into from
Aug 8, 2023

Conversation

smitch88
Copy link
Contributor

@smitch88 smitch88 commented Aug 2, 2023

Addresses issues #399, geofencing notice modal, and upgrades our wallet solution to support walletconnect v2 plus others thru rainbowkit

  • Removed old wallet provider solution in favor of wagmi + rainbowkit, though we are still leveraging version ~0.12.x so we do not need to do a full upgrade to viem from ethers
  • Fixes some styling bugs outlined after the latest reskin
  • Adds in the same geofence notice modal we show in OETH and OUSD dapps

Screenshots

Wallet connect
Screenshot 2023-08-02 143314

Screenshot 2023-08-02 143700

Active link
Screenshot 2023-08-02 143522

Title change
Screenshot 2023-08-02 143556

Address highlights in leaderboard and proposals
Screenshot 2023-08-02 143608

Screenshot 2023-08-02 143643

Geofence modal
Screenshot 2023-08-02 143721

@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-rdncxs August 2, 2023 18:30 Inactive
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-vwiixj August 2, 2023 18:39 Inactive
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-vmrndz August 2, 2023 19:19 Inactive
@smitch88 smitch88 temporarily deployed to ousd-governa-sbmitchell-4qeajg August 2, 2023 19:26 Inactive
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-dpsne1 August 2, 2023 20:06 Inactive
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-jhisos August 2, 2023 20:40 Inactive
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-nxbhbt August 2, 2023 21:28 Inactive
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-4zcozp August 2, 2023 21:46 Inactive
@micahalcorn micahalcorn removed the request for review from tomhirst August 8, 2023 07:23
@micahalcorn micahalcorn self-requested a review August 8, 2023 07:32
@rafaelugolini rafaelugolini temporarily deployed to ousd-governa-sbmitchell-ubesiv August 8, 2023 07:35 Inactive
Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -5,9 +5,11 @@ import { ToastContainer, toast } from "react-toastify";
import "react-toastify/dist/ReactToastify.css";
import { isMobile } from "react-device-detect";
import { useRouter } from "next/router";
import { ethers } from "ethers";
import { mainnetNetworkUrl } from "@/constants/index";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import?

client/utils/useBlock.tsx Show resolved Hide resolved
client/utils/useBlock.tsx Show resolved Hide resolved
client/utils/useHistoricalLockupToasts.js Outdated Show resolved Hide resolved
@smitch88 smitch88 temporarily deployed to ousd-governa-sbmitchell-ubesiv August 8, 2023 15:15 Inactive
@smitch88 smitch88 merged commit 6dbeff1 into master Aug 8, 2023
3 checks passed
@smitch88 smitch88 deleted the sbmitchell/governance-upgrades branch August 8, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants