Skip to content

Commit

Permalink
Tidy of TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
rob-baillie-ortoo committed Dec 13, 2021
1 parent 44dc4e7 commit bc87fc0
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions TODO.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,12 @@ Licenses that are needed with the source code and binary:
Look at the use of 'MockDatabase' in fflib

Test:
Unit of Work: elevatedContext

Look at:
SobjectUtils.getSobjectName
Do we need to add 'emptyRecycleBin' too?

Document:
Record level write access
If System Admin cannot access field
Effect of 'View All Data'


Test Manually:
Can I create a record that I can't update, even though I generally have rights - what happens?
Can I create a record that I can update, even though I generally don't have rights - what happens?


* To finalise the core architecture:
* Decide on FLS standards
* Do we need to have a non all-or-nothing version of commitWork?

Add to documentation
Expand Down Expand Up @@ -82,10 +70,6 @@ Bad Smells - strung out calls to describe methods - put them into SobjectUtils

* Question: How do we handle Constants - where are they defined?
* Question: How do we handle Exceptions:
* Question: How do we handle FLS - what are the rules?

* Where are they defined?
* Do we want to pass a single type of exception (e.g. ServiceException back to the client)?
* Do we handle individual types of exception in the Service?
* Do we pass any of the domain exceptions back

Expand All @@ -102,11 +86,5 @@ Bad Smells - strung out calls to describe methods - put them into SobjectUtils

* Dynamic building of the Unit Of Work for processing data

Standards?
* Selector name - singular or plural?
* When you have a class that wraps Sobject, what are the naming convensions - which one is called 'xxxObject'?
* Creating a service that performs DML - always provide an unwrapped version that takes a UOW
* Interfaces start with an I

Notes:
* Services should always be designed by seniors - at least which services exist

0 comments on commit bc87fc0

Please sign in to comment.