Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use always newest version of php-cs-fixer #15

Closed

Conversation

alexander-schranz
Copy link

I would use the newest version or make it configureable which version it should use and make it possible to use always the latest version.

@OskarStark
Copy link
Owner

currently it is „configurable“ via the docker tag which is based on the release on github.

@alexander-schranz
Copy link
Author

alexander-schranz commented Feb 17, 2020

@OskarStark Okay so this releases are greated automatically?

@OskarStark
Copy link
Owner

Unfortunately not, I do this whenever a new release is created 👎🏻
Automating this would be very nice, but I don’t know how

@Nyholm
Copy link
Contributor

Nyholm commented Apr 16, 2020

Lets merge this to a separate branch. v2

That will "solve" #17.
A user can then do the followng to always get the latest php-cs-fixer.

- name: PHP-CS-Fixer
        uses: OskarStark/php-cs-fixer-ga@v2
        with:
          args: --dry-run --diff-format udiff

There will be more maintenance cost to merge features into 2 branches. But Im not sure how many features that is usually added to this lib.

@OskarStark
Copy link
Owner

TBH I don't understand the problem here. using @master will always use the latest version of PHP-CS-Fixer

For a specific version you can use it, it gets tagged automatically on dockerhub.

@glensc
Copy link

glensc commented Oct 9, 2020

I agree with @OskarStark this PR is not needed, just that maintainer needs to keep on to push over @master each time the new version is updated.

however, I like the @v2 tag proposed by @Nyholm, to be somewhat semver compatible, in case php-cs-fixer v3 appears.

@fabiofdsantos
Copy link
Contributor

Unfortunately not, I do this whenever a new release is created 👎🏻
Automating this would be very nice, but I don’t know how

We can do it via a GitHub action but it requires some implementation effort ofc..

@rdwebdesign
Copy link

rdwebdesign commented Aug 7, 2022

I think this action could help here: https://github.com/marketplace/actions/find-latest-tag.

@OskarStark
Copy link
Owner

OskarStark commented Sep 1, 2023

@OskarStark OskarStark closed this Sep 6, 2023
@OskarStark
Copy link
Owner

See for more info:
OskarStark/phpstan-ga#58 (comment)

@alexander-schranz alexander-schranz deleted the patch-1 branch September 6, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants