-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use always newest version of php-cs-fixer #15
Conversation
currently it is „configurable“ via the docker tag which is based on the release on github. |
@OskarStark Okay so this releases are greated automatically? |
Unfortunately not, I do this whenever a new release is created 👎🏻 |
Lets merge this to a separate branch. That will "solve" #17. - name: PHP-CS-Fixer
uses: OskarStark/php-cs-fixer-ga@v2
with:
args: --dry-run --diff-format udiff There will be more maintenance cost to merge features into 2 branches. But Im not sure how many features that is usually added to this lib. |
TBH I don't understand the problem here. using For a specific version you can use it, it gets tagged automatically on dockerhub. |
I agree with @OskarStark this PR is not needed, just that maintainer needs to keep on to push over however, I like the |
We can do it via a GitHub action but it requires some implementation effort ofc.. |
I think this action could help here: https://github.com/marketplace/actions/find-latest-tag. |
See for more info: |
I would use the newest version or make it configureable which version it should use and make it possible to use always the latest version.