-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish docker image to docker hub automatically when a release is done #58
Conversation
aeb597f
to
44e01c8
Compare
if: github.ref == 'refs/heads/master' || github.event_name == 'release' | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't already tried v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work without issues, but lets keep it for now
Done ✅ |
I will create a release |
Hmm, do we need to change something here?
|
This is for the auto-commit I think. |
Ok I triggered it manually for now, but an error occurred: See: |
That image not exists I think, I changed our docker too, see this commit @OskarStark |
PR: |
Hi @AlessandroMinoccheri, thanks again for this PR; I try to adapt it for the other repo in: Unfortunately, I think because PHP-CS-Fixer uses Maybe you can have a look and propose a PR? That would help me a lot, thank you! BTW, I invited you as a collaborator, so that you can trigger the workflow manually! Thanks in advance! ❤️ |
I am using the same strategy in this repo:
https://github.com/phparkitect/arkitect/blob/main/.github/workflows/build.yml
So when a new release is created, GitHub Actions automatically push the docker image with a tag into the docker hub.
It's important to add in the repository two secrets:
DOCKERHUB_USERNAME
,DOCKERHUB_TOKEN