This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Code cleaning #64
Merged
Code cleaning #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docstrings and comments; remove print statements; remove useless legacy functions in `utils.py`.
The dropout rate was wrongly implemented, as putting it as a command argument did not change anything: the corresponding value was not taken into account, and a 75% dropout rate was considered. This commit fixes the issue, by setting dropout as an attribute of class ConvolutionalNeuralNetwork and its derivatives.
garaud
suggested changes
May 3, 2018
setup.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| version = line.strip().split('=')[1].strip(' \'"') | |||
| break | |||
| else: | |||
| version = '0.3.2' | |||
| version = '0.4' | |||
There was a problem hiding this comment.
maybe write also the version number in the __init__.py file. What to you think?
There was a problem hiding this comment.
Yes you're write, it seems to be a good practice. Should I modify the setup.py too, or should we keep the version in both scripts?
There was a problem hiding this comment.
we can keep the version in both scripts. I'll look for another open source projects how they deal with that.
| + numpy | ||
| + pandas | ||
| + PIL | ||
| + tensorflow |
There was a problem hiding this comment.
maybe mention the setup.py file with the dependencies and the requitements dev file if needed.
|
Some new commits have been added to fit your remarks. If everything is OK, we can merge, and release the new code version. |
garaud
approved these changes
May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleaning operations to prepare the
0.4release:setup.pyREADME.mdFixes the issue #63 .