Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue listing files on windows #13

Closed
NuclearCookie opened this issue Aug 14, 2015 · 6 comments
Closed

Issue listing files on windows #13

NuclearCookie opened this issue Aug 14, 2015 · 6 comments

Comments

@NuclearCookie
Copy link

Hi, If I'm on windows I have troubles listing the file content of the current directory. It looks like it's related to the windows style paths. For example:

C:\Projects\TestProject will list nothing, where \Projects\TestProject will show all directories..
Osmose pushed a commit that referenced this issue Aug 17, 2015
Fix #13: Fix Windows path handling.
51e18e6 
Also removes support for creating multiple files at once; refactoring
the code to support Windows paths created some bugs that involved fixing
the multiple-file code, which I didn't think we needed anyway.
@traverse traverse mentioned this issue Sep 1, 2015
Closed
@Osmose Osmose closed this as completed in 5bcf12d Sep 3, 2015
@Osmose Osmose mentioned this issue Sep 3, 2015
Merged
@Osmose
Copy link
Owner

Osmose commented Sep 3, 2015

@NuclearCookie This is closed because 5bcf12d landed, but if you're still having issues, could you please reopen with info on which version of windows and what kind of paths you're having trouble opening?

@Osmose
Copy link
Owner

Osmose commented Sep 3, 2015

Oh yeah. I forgot to ask.

@traverse, have you even seen any issues similar to this?

@traverse
Copy link

traverse commented Sep 4, 2015

Yes I did have similar issues also this was directly related to #21 since by default it was using the full windows path C:\Projects\TestProject which meant there were no directories being listed and thus tab auto-completion wouldn't work because you can't tab complete non-existent paths, \Projects\TestProject did list all the directories and thus tab auto-completion worked. So the issues were kind of intertwined.

@Osmose
Copy link
Owner

Osmose commented Sep 4, 2015

\Projects\TestProject works? That's surprising to me, I would've expected that it needed the C:\. I need to look up exactly how windows paths work in Node.

@NuclearCookie
Copy link
Author

Hey sorry for the inactivity. I'll see if I can test it today but I guess it's going to be fine ;)

@NuclearCookie
Copy link
Author

All good, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Osmose @NuclearCookie @traverse