-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LRU tab switching via Ctrl-Tab #52
Comments
Window screenshot after pressing ctrl-tab: http://yourcmc.ru/wiki/images/8/8e/Otter-after-ctrl-tab.png |
There are no special shortcuts for tab bar yet, probably some default ones cause issues. |
And are you planning to implement LRU? :-) |
That depends on what exactly "LRU" stands for in this context. :-D |
LRU is switching tabs in Least-Recently-Used order, as Alt-Tab does it for windows. (Maybe the correct term is MRU - Most Recently Used?) |
Ah, I would never guess that this term could be used in this context. Well, why not, I would go for combo box to select desired behavior (just like which tab should be activated after current will be closed). |
I think both behaviours should work simultaneously. There should be a pair of keybindings for Tab at Left and Tab at Right; and another pair for MRU Tab and LRU Tab. And Opera for the MRU/LRU Tab, Opera presented a list for that (Visual Studio also does this). Otter should also present it, but with an option to disable that list. May be Ctrl+Tab and Ctrl+Shift+Tab should not be used for MRU/LRU Tabs, but for Tab at Left/ Tab at Right. Only for the sake to make Otter more similar to the existing browsers. And, in that case, we should think on another pair for MRU/LRU Tabs. |
Yes, keybindings for next/prev tab are of course needed. I use 1/2 or F1/F2 for this in opera. Very convenient because those keys are always close to the left hand. |
I'd agree with vitalif in terms of the default functionality being similar to Opera's Ctrl-Tab as this is the same as almost all applications, and similar to Alt-Tab. Of course, these should all be "over-ridable" within the keyboard shortcuts. |
This feature is not ready yet. Opera displays a tabs dialogue when you switch tabs with Ctrl+Tab. Midori has implemented it pretty closely the way Opera has it. |
@ersi-dnd, I know (and I'll add something like that), this is why it's not marked as done yet. ;-) |
Does this report also concern single key bindings? |
@landroni, these are done already ( |
Oh, cool. What about other bindings, like |
@landroni, there seems to be conflict somewhere:
It could be our fault or some widget registering it for itself out of the box ( |
@landroni Take a look inside your keyboard ini files and change them, try different things to get them to work. I personally deleted the default files completely, because some single-key shortcuts were heavily interfering (e.g. 2 was interfering with AltGr+2) while other were not working at all. It's good to build your own keyboard shortcuts from ground up so you will know what is available and what works. Not everything works, and then you can report about it. Webkit seems to be full of keybind-eating and conflicts. |
@ersi-dnd, yep, that AltGr issue is confirmed upstream, it seems that this code path was created on English only system. ;-) |
@landroni, Z and X seems to work fine after that actions overhaul. |
Works for me. Thanks! |
Wouldn't this feature come "for free" with MDI? I think MDI window managers know the order in which windows were used (it's the order they use to draw them on screen, so that recent windows appear on top of older ones). This is why with the "click on tab to minimize" option in the old Opera, if you click the active tab, you automatically go to the last recently used tab, a really good feature IMO because you dont' even need to use the keyboard to go to the last recently used tab. |
@komoku, not in the way we want it. |
Thanks for this one. Works pretty well in full screen mode and allows selecting tabs with mouse too, almost like in Opera. The thing is that this function renders the tabbar largely obsolete, at least for those who don't need tab stacking. Therefore it would make sense to implement now #702 too :) |
@ersi-dnd, most of differences are intentional (maybe except lack of multi column support, hopefully someone will come up with good algorithm to handle it nicely, someday) to make it indeed a replacement for tab bar, so it won't close after mouse interaction. #702 will be done as part of #31, current approach is unreliable and not worth adding more workarounds, it needs to be done properly. |
… some more keys when it is visible, references #52
Thanks, just tested it. I have an issue - sometimes the tab switcher shows up, but it doesn't switch the tab from the current one. It seems it happens when I'm pressing ctrl and tab too fast... almost simultaneously...? Can you try and check? I can post a screencast if it helps you. |
@vitalif, yeah, screencast could be useful, so far I couldn't reproduce that. |
In fact I'm not sure it will help, but... |
@vitalif, I've managed to reproduce it few times, it looks like a race condition, key release event being fired before tab gets selected. Currently I'm considering different strategy for such cases, completely skipping dialog if Control will be released sooner than ~100 milliseconds since key press event. |
1 and 2 aren't very convenient. If the previous/current tab currently has a form highlighted, ��it will not be able to switch tabs. Why not leave ctrl-tab and ctrl-shift-tab's default behaviour? Alternatively, provide a way to make its behaviour equal to other browsers'. |
F1/F2 are good. |
@lc-guy: ctrl+tab should follow the standard behaviour - switch through the tabs in "most recently used" order. This is the way alt+tab works in the OS, and ctrl+tab works in other applications (just not Chrome and Firefox). The reason behind this is simple: Chrome and Firefox were only really designed for a dozen or so tabs, not too many to cycle through the lot. Operating systems are designed for a lot more applications at once, and most applications that have "tabs" are designed for a lot more tabs than Chrome and Firefox. As such, switching between most recently used is... logical. Worth noting here, Opera 12.x was designed to handle a hell of a lot of tabs, and they chose the most recently used method - and it looks like Otter will follow many of the same decisions. If you wish to cycle through the tabs in their display order, then you can override (in the keyboard shortcuts) or use 1+2. |
Hi!
One of the basic features of Opera is LRU tab switching out of the box.
I'm not sure if you've already implemented keyboard shortcuts in otter (all controls on keyboard page in preferences are grayed), but for me Ctrl-Tab works very strange - when I press it, otter does not switch tabs, but the current tab becomes gray as if the web view with address bar and everything was removed. It seems like a bug to me :-)
The text was updated successfully, but these errors were encountered: