provide details for debugging failing test-thredds notebook #87
Conversation
…oc notes relevant for debuging
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…rmission-update/access-requests
| @@ -56,15 +56,15 @@ | |||
| "import requests\n", | |||
| "print(\"Setup configuration parameters...\")\n", | |||
| "\n", | |||
| "PAVICS_HOST = os.getenv(\"PAVICS_HOST\", \"pavics.ouranos.ca\").rstrip(\"/\")\n", | |||
| "PAVICS_HOST = (os.getenv(\"PAVICS_HOST\") or \"pavics.ouranos.ca\").rstrip(\"/\")\n", | |||
There was a problem hiding this comment.
Just curious, os.getenv("VAR_NAME", default_value) do not work so you have to do os.getenv("VAR_NAME") or default_value? I know both achieve the same effect so I am not against the other format but I just wonder what is the subtleties that make you change to the other form.
There was a problem hiding this comment.
os.getenv("VAR_NAME", default_value) will return an empty string or None if the variable is defined with VAR_NAME= or VAR_NAME="". In this case, I want to consider empty equivalent as undefined and revert to the default. The default_value is picked only if there was no export VAR_NAME anywhere.
There was a problem hiding this comment.
I see! That "empty value" problem did happen via Jenkins build request or you are being defensive for when invoking pytest manually directly on the command-line and user can accidentally introduce the problem?
There was a problem hiding this comment.
I had this issue when testing locally.
I have a script that allows me to quickly source an .env file and spin up a Jupyter server connected to a deployed daccs-iac instance. The issue I faced was that this script only updates variables (cannot unset them), so I was overriding one of them as export VAR= to "unset" it, but the empty string remained.
I don't think it would impact any automated test suites because they all set their variables once.
Overview
Adds general debugging utilities regarding notebook
test_threddsChanges
test_threddsfor local debugging.test_thredds(based on actual issues encountered).Related Issue / Discussion