Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable caching feature of twitcher #188

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

fmigneault
Copy link
Collaborator

Overview

Re-enables the caching feature of Twitcher that was disabled temporarily in #182

Changes

Non-breaking changes

  • Twitcher request caching=on

Breaking changes
n/a

Related Issue / Discussion

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/594/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : cache-setting-on
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/521/

NOTEBOOK TEST RESULTS
    
[2021-08-04T18:24:30.967Z] ============================= test session starts ==============================
[2021-08-04T18:24:30.968Z] platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
[2021-08-04T18:24:30.968Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2021-08-04T18:24:30.968Z] plugins: anyio-3.3.0, dash-1.21.0, nbval-0.9.6, tornasync-0.6.0.post2
[2021-08-04T18:24:30.968Z] collected 210 items
[2021-08-04T18:24:30.968Z] 
[2021-08-04T18:24:36.002Z] notebooks-auth/test_thredds.ipynb .......FF.                             [  4%]
[2021-08-04T18:24:57.619Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  8%]
[2021-08-04T18:25:07.127Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2021-08-04T18:25:15.897Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 14%]
[2021-08-04T18:25:18.374Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 19%]
[2021-08-04T18:25:33.296Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .                 [ 20%]
[2021-08-04T18:25:33.296Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 20%]
[2021-08-04T18:25:39.390Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 23%]
[2021-08-04T18:25:46.216Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 26%]
[2021-08-04T18:29:02.961Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 33%]
[2021-08-04T18:30:03.496Z] ...............                                                          [ 40%]
[2021-08-04T18:30:08.232Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 42%]
[2021-08-04T18:30:09.687Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 46%]
[2021-08-04T18:30:31.188Z] .................                                                        [ 54%]
[2021-08-04T18:30:37.918Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 56%]
[2021-08-04T18:30:47.711Z] finch-master/docs/source/notebooks/dap_subset.ipynb ..........           [ 61%]
[2021-08-04T18:30:56.062Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 64%]
[2021-08-04T18:31:39.956Z] finch-master/docs/source/notebooks/subset.ipynb ....................     [ 73%]
[2021-08-04T18:31:40.894Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 74%]
[2021-08-04T18:31:44.708Z] ......                                                                   [ 77%]
[2021-08-04T18:32:02.817Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 77%]
[2021-08-04T18:32:18.028Z] .............                                                            [ 83%]
[2021-08-04T18:32:28.020Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2021-08-04T18:33:10.980Z] ....s.                                                                   [ 87%]
[2021-08-04T18:33:23.190Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2021-08-04T18:33:31.060Z] ...                                                                      [ 89%]
[2021-08-04T18:33:49.152Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2021-08-04T18:34:15.400Z] ......                                                                   [ 92%]
[2021-08-04T18:34:23.548Z] notebooks/hummingbird.ipynb ............                                 [ 98%]
[2021-08-04T18:36:01.011Z] notebooks/stress-tests.ipynb ....                                        [100%]
[2021-08-04T18:36:01.011Z] 
[2021-08-04T18:36:01.011Z] =================================== FAILURES ===================================
    
  

@fmigneault
Copy link
Collaborator Author

run tests

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/595/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : cache-setting-on
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/522/

NOTEBOOK TEST RESULTS
    
[2021-08-04T19:53:35.730Z] ============================= test session starts ==============================
[2021-08-04T19:53:35.730Z] platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
[2021-08-04T19:53:35.730Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2021-08-04T19:53:35.730Z] plugins: anyio-3.3.0, dash-1.21.0, nbval-0.9.6, tornasync-0.6.0.post2
[2021-08-04T19:53:35.730Z] collected 210 items
[2021-08-04T19:53:35.730Z] 
[2021-08-04T19:53:40.723Z] notebooks-auth/test_thredds.ipynb .......FF.                             [  4%]
[2021-08-04T19:54:01.813Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  8%]
[2021-08-04T19:54:10.902Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2021-08-04T19:54:19.477Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 14%]
[2021-08-04T19:54:22.253Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 19%]
[2021-08-04T19:54:37.193Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .                 [ 20%]
[2021-08-04T19:54:37.194Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 20%]
[2021-08-04T19:54:44.518Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 23%]
[2021-08-04T19:54:50.979Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 26%]
[2021-08-04T19:57:51.382Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 33%]
[2021-08-04T19:58:49.200Z] ...............                                                          [ 40%]
[2021-08-04T19:58:51.944Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 42%]
[2021-08-04T19:58:53.722Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 46%]
[2021-08-04T19:59:17.206Z] .................                                                        [ 54%]
[2021-08-04T19:59:23.904Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 56%]
[2021-08-04T19:59:34.096Z] finch-master/docs/source/notebooks/dap_subset.ipynb ..........           [ 61%]
[2021-08-04T19:59:41.844Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 64%]
[2021-08-04T20:00:25.942Z] finch-master/docs/source/notebooks/subset.ipynb ....................     [ 73%]
[2021-08-04T20:00:25.942Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 74%]
[2021-08-04T20:00:29.314Z] ......                                                                   [ 77%]
[2021-08-04T20:00:55.896Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 77%]
[2021-08-04T20:01:19.660Z] .............                                                            [ 83%]
[2021-08-04T20:01:29.678Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2021-08-04T20:02:42.079Z] ....s.                                                                   [ 87%]
[2021-08-04T20:02:52.126Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2021-08-04T20:02:58.808Z] ...                                                                      [ 89%]
[2021-08-04T20:03:16.898Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2021-08-04T20:03:45.838Z] ......                                                                   [ 92%]
[2021-08-04T20:03:53.253Z] notebooks/hummingbird.ipynb ............                                 [ 98%]
[2021-08-04T20:05:31.581Z] notebooks/stress-tests.ipynb ....                                        [100%]
[2021-08-04T20:05:31.582Z] 
[2021-08-04T20:05:31.582Z] =================================== FAILURES ===================================
    
  

@fmigneault
Copy link
Collaborator Author

run tests

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/596/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : cache-setting-on
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/526/

NOTEBOOK TEST RESULTS
    
[2021-08-09T21:12:10.026Z] ============================= test session starts ==============================
[2021-08-09T21:12:10.027Z] platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
[2021-08-09T21:12:10.027Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2021-08-09T21:12:10.027Z] plugins: anyio-3.3.0, dash-1.21.0, nbval-0.9.6, tornasync-0.6.0.post2
[2021-08-09T21:12:10.027Z] collected 210 items
[2021-08-09T21:12:10.027Z] 
[2021-08-09T21:12:16.172Z] notebooks-auth/test_thredds.ipynb .......FF.                             [  4%]
[2021-08-09T21:12:48.420Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  8%]
[2021-08-09T21:12:59.297Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2021-08-09T21:13:08.782Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 14%]
[2021-08-09T21:13:11.077Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 19%]
[2021-08-09T21:13:29.229Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .                 [ 20%]
[2021-08-09T21:13:29.229Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 20%]
[2021-08-09T21:13:32.950Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 23%]
[2021-08-09T21:13:39.428Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 26%]
[2021-08-09T21:18:00.566Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 33%]
[2021-08-09T21:18:55.596Z] ...............                                                          [ 40%]
[2021-08-09T21:19:02.182Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 42%]
[2021-08-09T21:19:04.083Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 46%]
[2021-08-09T21:19:26.220Z] .................                                                        [ 54%]
[2021-08-09T21:19:32.305Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 56%]
[2021-08-09T21:19:42.425Z] finch-master/docs/source/notebooks/dap_subset.ipynb ..........           [ 61%]
[2021-08-09T21:19:50.152Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 64%]
[2021-08-09T21:20:32.498Z] finch-master/docs/source/notebooks/subset.ipynb ....................     [ 73%]
[2021-08-09T21:20:33.451Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 74%]
[2021-08-09T21:20:37.522Z] ......                                                                   [ 77%]
[2021-08-09T21:21:04.092Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 77%]
[2021-08-09T21:21:21.819Z] .............                                                            [ 83%]
[2021-08-09T21:21:31.796Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2021-08-09T21:23:33.664Z] ....s.                                                                   [ 87%]
[2021-08-09T21:23:48.530Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2021-08-09T21:23:55.266Z] ...                                                                      [ 89%]
[2021-08-09T21:24:27.368Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2021-08-09T21:24:56.851Z] ......                                                                   [ 92%]
[2021-08-09T21:25:02.506Z] notebooks/hummingbird.ipynb ............                                 [ 98%]
[2021-08-09T21:26:24.953Z] notebooks/stress-tests.ipynb ....                                        [100%]
[2021-08-09T21:26:24.954Z] 
[2021-08-09T21:26:24.954Z] =================================== FAILURES ===================================
    
  

@fmigneault
Copy link
Collaborator Author

fmigneault commented Aug 9, 2021

@tlvu @dbyrns
Following 3 previous test runs with a good interval between each execution, I tend to believe that caching is not at cause of the failing test (2 specifically with thredds).

I'm not sure what could be the cause though as those tests seem to work correctly without caching (ex: in this recent PR).

Edit:
I think I might have a lead...
What I think is happening is that when running test_thredds, the first few cells target some file endpoints with only default permissions applied.
Because of omitted permissions on the group and user inheriting from it, the first few request correctly return forbidden access to the secured file.
Following cells in the test apply the relevant permissions on the group to grant access to the file for the user member of the group.
Because of caching, the resolved access (denied) remains the same as the initial cell for about 20s (configured caching expire time).
When running the failing cell a second time (after delay passed), everything resolves fine (allowed access).

details in #189
addressed in Ouranosinc/PAVICS-e2e-workflow-tests#87

fmigneault added a commit to Ouranosinc/PAVICS-e2e-workflow-tests that referenced this pull request Aug 24, 2021
# Overview

Adds general debugging utilities regarding notebook `test_thredds`

## Changes

- Adds variable overrides in `test_thredds` for local debugging. 
- Adds important documentation notes regarding possible error debugging leads for `test_thredds` (based on actual issues encountered). 

## Related Issue / Discussion

- Relates to bird-house/birdhouse-deploy#188 (comment)
@dbyrns
Copy link
Collaborator

dbyrns commented Aug 30, 2021

Does Ouranosinc/PAVICS-e2e-workflow-tests@10a784a helps somehow or the errors are still the same?

@fmigneault
Copy link
Collaborator Author

@dbyrns Errors should be gone because it enforces no cache. Let's test it again...

@fmigneault
Copy link
Collaborator Author

run tests

@fmigneault fmigneault requested review from dbyrns and tlvu August 30, 2021 21:12
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/600/
Result : success

BIRDHOUSE_DEPLOY_BRANCH : cache-setting-on
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-36.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/533/

NOTEBOOK TEST RESULTS
    
[2021-08-30T21:20:12.679Z] ============================= test session starts ==============================
[2021-08-30T21:20:12.680Z] platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
[2021-08-30T21:20:12.680Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2021-08-30T21:20:12.680Z] plugins: anyio-3.3.0, dash-1.21.0, nbval-0.9.6, tornasync-0.6.0.post2
[2021-08-30T21:20:12.680Z] collected 211 items
[2021-08-30T21:20:12.680Z] 
[2021-08-30T21:20:21.337Z] notebooks-auth/test_thredds.ipynb ...........                            [  5%]
[2021-08-30T21:20:45.226Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  8%]
[2021-08-30T21:20:56.119Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 11%]
[2021-08-30T21:21:04.817Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 15%]
[2021-08-30T21:21:06.968Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 19%]
[2021-08-30T21:21:25.113Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .                 [ 20%]
[2021-08-30T21:21:25.113Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 20%]
[2021-08-30T21:21:30.189Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 24%]
[2021-08-30T21:21:37.448Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 26%]
[2021-08-30T21:24:56.268Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 33%]
[2021-08-30T21:25:51.580Z] ...............                                                          [ 40%]
[2021-08-30T21:25:55.842Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 42%]
[2021-08-30T21:25:57.412Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 46%]
[2021-08-30T21:26:23.249Z] .................                                                        [ 54%]
[2021-08-30T21:26:29.974Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 56%]
[2021-08-30T21:26:40.551Z] finch-master/docs/source/notebooks/dap_subset.ipynb ..........           [ 61%]
[2021-08-30T21:26:48.914Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 64%]
[2021-08-30T21:27:33.957Z] finch-master/docs/source/notebooks/subset.ipynb ....................     [ 73%]
[2021-08-30T21:27:33.957Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 74%]
[2021-08-30T21:27:37.547Z] ......                                                                   [ 77%]
[2021-08-30T21:28:04.140Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 77%]
[2021-08-30T21:28:19.643Z] .............                                                            [ 83%]
[2021-08-30T21:28:29.632Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2021-08-30T21:30:23.590Z] ....s.                                                                   [ 87%]
[2021-08-30T21:30:35.836Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2021-08-30T21:30:42.033Z] ...                                                                      [ 89%]
[2021-08-30T21:31:08.618Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2021-08-30T21:31:37.295Z] ......                                                                   [ 92%]
[2021-08-30T21:31:42.390Z] notebooks/hummingbird.ipynb ............                                 [ 98%]
[2021-08-30T21:33:20.327Z] notebooks/stress-tests.ipynb ....                                        [100%]
[2021-08-30T21:33:20.327Z] 
[2021-08-30T21:33:20.327Z] ================== 210 passed, 1 skipped in 779.32s (0:12:59) ==================
    
  

Copy link
Collaborator

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a winner!

@fmigneault
Copy link
Collaborator Author

@tlvu
Tests are all passing now. I plan to merge this soon if you find it's ready too.

@tlvu
Copy link
Collaborator

tlvu commented Sep 1, 2021

@tlvu
Tests are all passing now. I plan to merge this soon if you find it's ready too.

I think you can go. I have not seen the stress-tests.ipynb fail since 3 weeks (it was failing almost everyday before) so let's try the caching again.

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I realized I forgot to approve, here it is.

@fmigneault fmigneault merged commit 7dded91 into master Sep 1, 2021
@fmigneault fmigneault deleted the cache-setting-on branch September 1, 2021 19:01
@tlvu
Copy link
Collaborator

tlvu commented Sep 1, 2021

Huh, no bump2version jazz?

@tlvu
Copy link
Collaborator

tlvu commented Sep 1, 2021

And CHANGES.md update ... You're the one who put these process into place :D

fmigneault added a commit that referenced this pull request Sep 1, 2021
fmigneault added a commit that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Intermittent UnauthorizedException for WPS processes behind Magpie 3.8.0 and matching Twitcher
4 participants