Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bibliography and other adjustments #1176

Merged
merged 8 commits into from
Sep 6, 2022
Merged

Bibliography and other adjustments #1176

merged 8 commits into from
Sep 6, 2022

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Sep 1, 2022 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added
  • The relevant author information has been added to AUTHORS.rst and .zenodo.json

What kind of change does this PR introduce?

  • Adds pybtex to development dependencies (used in docs/conf.py)
  • Reverts the conditional bibliography changes for all builds of docs
  • Removes the latex-generated bibliography automatically generated in latexpdf mode

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre
add pybtex to development dependencies, do not build bibliography in …
55cc035 
…late, always render bibliography in indices.rst
@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward information For development/intsructional purposes labels Sep 1, 2022
@Zeitsperre Zeitsperre added this to the v0.38 milestone Sep 1, 2022
@Zeitsperre
Copy link
Collaborator Author

@aulemahal feel free to add your docs changes in here!

@coveralls
Copy link

coveralls commented Sep 6, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 92.327% when pulling b2e4674 on doc_references_adjustments into e13a420 on master.

@Zeitsperre Zeitsperre marked this pull request as ready for review September 6, 2022 17:34
aulemahal
aulemahal approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.readthedocs.yml Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit f218690 into master Sep 6, 2022
@Zeitsperre Zeitsperre deleted the doc_references_adjustments branch September 6, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

@aulemahal aulemahal

Labels
information For development/intsructional purposes standards / conventions Suggestions on ways forward
Projects
None yet
Milestone
v0.38
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @aulemahal