Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-10685 - [OSMaps] - Leaflet misbehavior when changing marker location after zooming out with more than 2 markers #178

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

This PR is for fixing the pan/zoom on the leaflet map when reacting to the markers update.

What was happening

  • When markers were added or deleted on the leaflet map, the autofit behavior was not happening as supposed

What was done

  • Use SetView on refreshZoom to guarantee the center is the latest;

Test Steps

  1. Go to the Sample
  2. Add various icons and delete some of them
  3. Check if the map reacts as expected
  4. Toggle the "Respect user zoom"
  5. Interact again with the markers and do some zooms
  6. Check if the map reacts as expected

Screenshots

LeafletMarkers_reacting

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner June 12, 2024 10:53
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit cf4e934 into dev Jun 21, 2024
13 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-10685 branch June 21, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants