Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day/Night Audio/Music #319

Closed
mrwallace888 opened this issue Aug 28, 2022 · 0 comments · Fixed by #655
Closed

Day/Night Audio/Music #319

mrwallace888 opened this issue Aug 28, 2022 · 0 comments · Fixed by #655
Assignees
Labels
feature Features that should be implemented fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@mrwallace888
Copy link

Feature

Music or sounds that play only during the day on a planet or only at night.

Context

No response

@mrwallace888 mrwallace888 added the feature Features that should be implemented label Aug 28, 2022
@xen-42 xen-42 self-assigned this Sep 3, 2022
MegaPiggy added a commit that referenced this issue Jul 20, 2023
## Major features
- Added new day/night audio volume. Switches between two clips depending
on the time of day. Resolves #319 .
@MegaPiggy MegaPiggy mentioned this issue Jul 20, 2023
@xen-42 xen-42 added the fixed in dev Instead of closing issues when you fix them in dev just add this. label Jul 20, 2023
MegaPiggy added a commit that referenced this issue Jul 20, 2023
## Minor features
- Added `activationCondition` and `deactivationCondition` to details,
allowing them to be enabled/disabled depending on a dialogue condition.
Resolves #482.
- Can now create empty game objects by having a prop detail without a
path.
- Added new day/night audio volume. Switches between two clips depending
on the time of day. Resolves #319.

## Improvements
- If the `path` for a detail is empty it will create an empty game
object now. This can be useful for adding other props to it as its
children.

## Bug fixes
- Black hole vanish effects now tied to the size of the black hole.
Fixes #215.
- Black hole ambience pitch isn't weirdly high for large black holes
anymore. Fixes #226.
- Change system black holes now make a sound when entering them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features that should be implemented fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants