Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolls Ignore Rotation Parameter #457

Closed
2walker2 opened this issue Dec 3, 2022 · 0 comments
Closed

Scrolls Ignore Rotation Parameter #457

2walker2 opened this issue Dec 3, 2022 · 0 comments
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@2walker2
Copy link

2walker2 commented Dec 3, 2022

What Happened?

Scrolls ignore the rotation parameter when placed. They all align in the same direction regardless of rotation specified. This makes it impossible to align them with shelves.

What was supposed to happen?

Scrolls should take into account the rotation parameter when placed.

Platform

Steam

Mods

New Horizons + Dependencies
Developer Console + Console Cheats
Unity Explorer
Astral Codex

Logs

When the scroll spawns. No errors listed.
@2walker2 2walker2 added the bug Something isn't working label Dec 3, 2022
xen-42 added a commit that referenced this issue Dec 12, 2022
@xen-42
[Bug] [#457] Make scrolls use rotation parameter
d56a2f6
@xen-42 xen-42 added the fixed in dev Instead of closing issues when you fix them in dev just add this. label Dec 12, 2022
@xen-42 xen-42 mentioned this issue Dec 12, 2022
Merged
xen-42 added a commit that referenced this issue Dec 13, 2022
@xen-42
[Bug] [#457] Actually fix scroll rotation
6926ceb
JohnCorby added a commit that referenced this issue Dec 28, 2022
@JohnCorby
1.8.1 (#462)
ab4b510 
## Minor features
- #468 Added rename and parentPath to some more modules and infos

## Improvements
- The gameobjects for bramble nodes will be named their `name` if it's
provided
- Leaving sectors now unloads streamed things
- `pathToAnimController` now works for more things. Means entering
dialogue can stop them playing their instruments, change their
animation, and make them look at you.

## Bug fixes
- #457 Scrolls use the `rotation` parameter now
- #433 Stranger text is no longer fuzzy
- Recursive bramble dimensions no longer cause a hard crash
- The foglights in bramble nodes are now correctly colored
- Make streaming handler only load thing in if the player or probe
enters the sector
- Better error reporting in AudioUtilities
- Fixed a bug where renaming volcanoes didn't actually rename them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xen-42 @JohnCorby @2walker2