Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn override breaks if no ship spawn #738

Closed
xen-42 opened this issue Oct 4, 2023 · 0 comments · Fixed by #771
Closed

Spawn override breaks if no ship spawn #738

xen-42 opened this issue Oct 4, 2023 · 0 comments · Fixed by #771
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@xen-42
Copy link
Member

xen-42 commented Oct 4, 2023

What Happened?

Tries to put you into the ship which is inactive so you go out in space

What was supposed to happen?

Default to not doing that ig, some systems don't have player spawns only ship spawns for warping so we gotta check what spawns exist and then do whatever one we can.

Platform

None

Mods

No response

Logs

No response

@xen-42 xen-42 added the bug Something isn't working label Oct 4, 2023
@xen-42 xen-42 mentioned this issue Feb 3, 2024
@xen-42 xen-42 added the fixed in dev Instead of closing issues when you fix them in dev just add this. label Feb 3, 2024
@JohnCorby JohnCorby linked a pull request Feb 3, 2024 that will close this issue
@JohnCorby JohnCorby removed a link to a pull request Feb 3, 2024
@JohnCorby JohnCorby linked a pull request Feb 3, 2024 that will close this issue
xen-42 added a commit that referenced this issue Feb 4, 2024
## Minor features
- Can now set `preloadBundles` in the addon config file. This will load
asset bundles on the main menu and keep them loaded. Will improve
initial load times at the cost of more memory usage. (#749)
- Can now set `subtitlePath` in the addon config file for displaying a
subtitle for your mod on the main menu.

## Improvements
- Will show a warning popup if you have addons requiring the DLC
installed but not the DLC itself (#728).

## Bug fixes
- Fixes a bug where the ship was not removed from volumes when being
repositioned. Affected INSANE people who had stars larger than 8000m
wide.
- Probably fixes a bug where the ship would think it is grounded when
spawned in zero-g (#748).
- Fixed a bug where using system override to spawn in a ship-less system
would break (#738).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant