Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14.0 #684

Merged
merged 55 commits into from
Aug 8, 2023
Merged

1.14.0 #684

merged 55 commits into from
Aug 8, 2023

Conversation

xen-42
Copy link
Member

@xen-42 xen-42 commented Aug 5, 2023

Major features

  • Implement Nomai shuttles and gravity cannons. The gravity cannon also takes a position for a computer displaying where the shuttle is currently landed, and a position for the gravity cannon controls. Shuttles are linked to gravity cannons using the id and shuttleID parameters.
  • Added a CreateNomaiText method to the API that allows you to directly write Nomai text without loading from an external xml file.

Improvements

  • Load times are now faster when going to a new star system.

Bug fixes

  • Fix Nomai mask being coloured weird sometimes (let center of the universe die)
  • Make clearing default system options setting actually reset it
  • Details preserve sectors better. This means you can set up subsectors in your own bundles and they should work.
  • Shadows glitch out way less
    • Custom planets now can have better, longer shadows (using ProxyShadowCaster and ProxyShadowCasterGroup from existing details and in bundles)
    • Shadows no longer jitter
    • Note: short-distance shadows still cast from planets behind suns. However, this also happens in vanilla, so it is not fixed here

@xen-42 xen-42 closed this Aug 5, 2023
@xen-42 xen-42 reopened this Aug 5, 2023
@xen-42 xen-42 marked this pull request as draft August 5, 2023 00:39
MegaPiggy and others added 2 commits August 5, 2023 00:17
## Major features
- Implement Nomai shuttles and gravity cannons. The gravity cannon also
takes a position for a computer displaying where the shuttle is
currently landed, and a position for the gravity cannon controls.
Shuttles are linked to gravity cannons using the `id` and `shuttleID`
parameters.
- Added a `CreateNomaiText` method to the API that allows you to
directly write Nomai text without loading from an external xml file.

## Improvements
- Load times should be somewhat faster when going to a new star system.
@xen-42 xen-42 changed the title 1.13.1 1.14.0 Aug 5, 2023
@MegaPiggy
Copy link
Member

:ghostCool:

@JohnCorby JohnCorby added the update-pr Marks pull requests as an update PR label Aug 5, 2023
@xen-42 xen-42 marked this pull request as ready for review August 6, 2023 02:39
@xen-42 xen-42 requested a review from JohnCorby August 6, 2023 02:39
Copy link
Member

@JohnCorby JohnCorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sun stuff got broken again, like when we didnt delay remove stock planets
specifically FaceActiveCamera and other components are disabled, but potentially other things i didnt catch
why does this happen?

also why does it break when we dont wait, idgi. will look into these things soon

@xen-42
Copy link
Member Author

xen-42 commented Aug 7, 2023

Have to find a better way of preserving the CDATA for the shuttle computer texture because it breaks UI for volume popups, we might want to either make an entirely different section for directly getting xml translations which would include CDATA

@xen-42 xen-42 marked this pull request as draft August 7, 2023 14:14
JohnCorby and others added 12 commits August 7, 2023 15:12
<!-- A new module or something else important -->
## Major features
-

<!-- A new parameter added to a module, or API feature -->
## Minor features
-

<!-- Some improvement that requires no action on the part of add-on
creators i.e., improved star graphics -->
## Improvements
-

<!-- Be sure to reference the existing issue if it exists -->
## Bug fixes
- Shadows glitch out way less
- Custom planets now can have better, longer shadows (using
ProxyShadowCaster and ProxyShadowCasterGroup from existing details and
in bundles)
  - Shadows no longer jitter
- Note: short-distance shadows still cast from planets behind suns.
However, this also happens in vanilla, so it is not fixed here
@xen-42 xen-42 marked this pull request as ready for review August 8, 2023 04:40
@JohnCorby JohnCorby merged commit 194aae1 into main Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-pr Marks pull requests as an update PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants