Skip to content

Commit

Permalink
jobs: NIN update pulse condition and raidbuff position (#213)
Browse files Browse the repository at this point in the history
fix kazematoi cannot stop pulsing and raidbuff overlaps with resource
box.

---------

Co-authored-by: Maiko Sinkyaet Tan <maiko.tan.coding@gmail.com>
  • Loading branch information
Echoring and MaikoTan committed Jul 9, 2024
1 parent afc60f7 commit 73e31e7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
16 changes: 7 additions & 9 deletions ui/jobs/components/nin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,6 @@ export class NINComponent extends BaseComponent {
}, 15000);
break;
}
case kAbility.ArmorCrush: {
if (+this.kazematoi.innerText >= 4) {
// Pulse the kazematoi count to indicate that you are wasting it.
this.kazematoi.parentElement?.classList.add('nin-kazematoi', 'pulse');
} else {
this.kazematoi.parentElement?.classList.remove('nin-kazematoi', 'pulse');
}
break;
}
}
}

Expand All @@ -135,6 +126,12 @@ export class NINComponent extends BaseComponent {
this.ninki.parentNode.classList.add('high');

this.kazematoi.innerText = jobDetail.kazematoi?.toString() ?? '0';
if (jobDetail.kazematoi >= 4) {
// Pulse the kazematoi count to indicate that you shouldn't use Armor Crash again.
this.kazematoi.parentElement?.classList.add('nin-kazematoi', 'pulse');
} else {
this.kazematoi.parentElement?.classList.remove('nin-kazematoi', 'pulse');
}
}
override onCombo(skill: string, combo: ComboTracker): void {
this.comboTimer.duration = 0;
Expand All @@ -147,6 +144,7 @@ export class NINComponent extends BaseComponent {
override reset(): void {
this.bunshin.duration = 0;
this.kazematoi.innerText = '0';
this.kazematoi.parentElement?.classList.remove('nin-kazematoi', 'pulse');
this.mudraTriggerCd = true;
this.ninjutsu.duration = 0;
this.trickAttack.duration = 0;
Expand Down
1 change: 1 addition & 0 deletions ui/jobs/jobs.css
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ div.justbuffs div#procs-container {

/* Space for 2 resource boxes */
.drg #right-side-icons,
.nin #right-side-icons,
.sam #right-side-icons,
.rpr #right-side-icons,
.brd #right-side-icons,
Expand Down

0 comments on commit 73e31e7

Please sign in to comment.