Fix Various Recurring Issues #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t when there is a list of recurring events plus some "modified" events. The modified events are denoted by the RECURRENCE-ID in the VEVENT properties.
… the recurrence array.
…nce it is. This is important for creating unique IDs such as UID + SEQUENCE + RECURRENCE_INSTANCE
…RRENCE-IDs are processed. Some badly formed ICS files put events after the recurring event, which I refactored some code to handle.
…have weird characters in them. Fixed a bug with recurring events that have changes to them.
…e on Monday of every week). Added tests for this also.
…pdated tests to work properly and to evaluate the actual events generated versus the recurrence dates.
This was referenced Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two years ago I submitted PR #16 to add support for recurring events. After that was manually merged, my fork drifted away from this repo and I couldn't submit bug fixes I'd made on my fork. I spent some time and rebased my fork with the latest changes from this repo. This PR includes fixes for recurring events that I encountered, updated many test cases to highlight these advanced issues, and fixed many timezone name issues (specifically with Office365 calendars).
This should fix issues #5, #19, and #27.