Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Latest version broke Symbol Browser #68

Closed
leereichardt opened this issue Nov 27, 2017 · 6 comments
Closed

Latest version broke Symbol Browser #68

leereichardt opened this issue Nov 27, 2017 · 6 comments

Comments

@leereichardt
Copy link

The latest version has completely broken the symbol browser in ST3 where the window is filled with everything

WITHOUT:
screenshot 2017-11-28 11 57 35

Installed:
screenshot 2017-11-28 11 56 57

As you can see with it being installed, it's completely filled the symbol browser with everything single variable or mention of a variable in the current file

@P233
Copy link
Owner

P233 commented Nov 28, 2017

Sorry for the issue and my late reply. I added too many things to the symbols list. I'll remove everything else in the symbols list except the mixin and function definition. Does that sound good? Or what other elements would you like to list in the symbols list?

@leereichardt
Copy link
Author

Is it possible to a set a scope as well, as this is affecting non-scss files? Mixins and functions are a good idea though.

@evandrocoan
Copy link

This was also reported on the Sublime Text forum:

  1. https://forum.sublimetext.com/t/goto-symbol-not-working/33653 Goto Symbol not working?

The user had to revert Sublime Text to a clean install, and reintroduce his packages until find out this package was causing the problem.

@FichteFoll
Copy link

FichteFoll commented Nov 29, 2017

Your preferences selector was the following:

entity.name.tag, entity.other.attribute-name.id, entity.other.attribute-name.class, variable

Any region matching that selector in any view would get added to the symbol list. Notably, each variable occurance (not definition!). By convention, definitions are scoped as entity.name.<something>, e.g. entity.name.function, and you should look into adding that to the symol list. You should also tie the selector to your syntax only by being more explicit, e.g. entity.name.function.sass or source.sass entity.name.

@P233
Copy link
Owner

P233 commented Nov 30, 2017

I am really sorry about the issue. I have removed my stupid preferences, therefore only mixin and function definitions can be listed in the symbols list.

@leereichardt
Copy link
Author

Great thanks,

@P233 P233 closed this as completed Dec 1, 2017
evandrocoan added a commit to evandrocoan/ITE that referenced this issue Dec 21, 2017
issues:
Latest version broke Symbol Browser
P233/Syntax-highlighting-for-Sass#68

Sublime Text hangs when hovering a symbol which has much, much definitions and references
sublimehq/sublime_text#2103
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants