Fixed proper exit of a peer after removal from peer_list #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We receive a negative chunk number whenever there is a socket timeout (process_next_message() function). However in line 479, we keep on waiting for the chunks whenever there is a negative chunk number.
If the splitter removes a particular peer from the peer_list, the splitter no longer sends the chunks to the peer , so do the other peers.
Also, since this is a UDP socket, there might be packet losses.
Hence, technically the peer will never get to know if the socket timeout is because of UDP or because it was removed from the peer_list.
One way to resolve this issue is to wait for a certain amount of time before stopping the peer thread.
I have chosen this time interval as 15 seconds. This can be modified as required.