Fix Austin on WSL failing to find BSS section from maps file. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser of the maps file on Linux is broken on WSL. We bite the bullet and use sscanf to thoroughly parse the maps file. Also fixed the reporting of bad samples in the stats.
P403n1x87
added a commit
that referenced
this pull request
Oct 20, 2019
What's New: * Added multi-process support (#35) * Added support for Python 3.8 (#33) * Added memory profile/multi-process support to TUI and Web tools (#34) * Added sample Speedscope support (#36) * Added Debian package badge (#30) Bugfixes: * Fixed Austin on WSL failing to find BSS section from maps file. (#29) * Fixed report of bad samples in stats. Issues: * Closes #32 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The parser of the maps file on Linux is broken on WSL. We bite the
bullet and use
sscanfto thoroughly parse the maps file.Also fixed the reporting of bad samples in the stats.
Alternate Designs
Small fix; no alternative designs required.
Regressions
Non expected.
Verification Process
The existing test suite.