Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor InterpreterControls for readability, debugability, and performance. #1251

Merged
merged 0 commits into from
Aug 11, 2023
Merged

Refactor InterpreterControls for readability, debugability, and performance. #1251

merged 0 commits into from
Aug 11, 2023

Conversation

copybara-service[bot]
Copy link

Refactor InterpreterControls for readability, debugability, and performance.

  • Disassociates @observable and @Property() decorators where appropriate.
  • Computes the defaultSettings when the Spec changes.
  • Resets the settings when the defaultSettings.
  • Removes any code that changed a settings property in the render() loop.
  • Refactors the rendering code to fallback to defaultSettings if the value is settings is undefined.
  • Refactors settings assignment code for stability.

@copybara-service copybara-service bot force-pushed the test_555164555 branch 3 times, most recently from 8d36f28 to c4d55eb Compare August 11, 2023 11:37
@copybara-service copybara-service bot closed this Aug 11, 2023
@copybara-service copybara-service bot merged commit d25392b into dev Aug 11, 2023
@copybara-service copybara-service bot deleted the test_555164555 branch August 11, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants