Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import os in glue_models.py #37

Merged
merged 1 commit into from
Sep 8, 2020
Merged

import os in glue_models.py #37

merged 1 commit into from
Sep 8, 2020

Conversation

lgessler
Copy link
Contributor

@lgessler lgessler commented Sep 6, 2020

It is needed by GlueModel.save

It is needed by `GlueModel.save`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lgessler
Copy link
Contributor Author

lgessler commented Sep 6, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jameswex jameswex merged commit 32c4754 into PAIR-code:main Sep 8, 2020
@jameswex
Copy link
Collaborator

jameswex commented Sep 8, 2020

Thanks @lgessler for finding the issue and providing a fix. Looks like this was due to an error in our process of importing the code to GitHub. We'll fix our import script to ensure we don't have this regression again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants