Remove previous polylines when updating point positions. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annxingyuan
changed the title
|
Nice! Thanks for this, seems like a necessary fix (I never really did anything with the polylines) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note It's very possible that this PR is unnecessary and I'm missing a way to do this through the existing API! :)
This PR makes it so that when the point positions of the polylines are updated, the previous polylines are removed. Otherwise if you try to setSequences and animate the points, the polyline geometries will accumulate with every update of the point positions.
Note this feature is being used in the handpose demo: https://storage.googleapis.com/tfjs-models/demos/handpose/index.html