Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JupyterLab 3.x and bump version number #183

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add support for JupyterLab 3.x and bump version number #183

merged 1 commit into from
Oct 12, 2021

Conversation

jameswex
Copy link
Collaborator

@jameswex jameswex commented Oct 5, 2021

  • Add support for JupyterLab 3.x (tested locally and in Vertex AI notebooks)
  • Bump version number to 1.8.1
  • Remove unneeded pip package dep on jupyter as this package is only used in the context of jupyter notebooks anyways.

@jameswex jameswex requested a review from tolga-b October 5, 2021 12:45
@jameswex
Copy link
Collaborator Author

jameswex commented Oct 5, 2021

Also tested in colab to ensure no regressions there.

@jameswex
Copy link
Collaborator Author

jameswex commented Oct 5, 2021

Fixes #182

tolga-b
tolga-b approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@tolga-b tolga-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you James, I assume you tested this in the Jupyterlab notebook.

witwidget/pip_package/setup.py
@@ -37,7 +37,6 @@
'absl-py >= 0.4',
'google-api-python-client>=1.7.8',
'ipywidgets>=7.0.0',
'jupyter>=1.0,<2',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this from a template? should we still keep >=1.0, <4 or something to denote we support up to version 3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with tolga offline, no need for this dep as witwidget is only used in the context of jupyter environments already.

@jameswex jameswex merged commit 3d76f8f into master Oct 12, 2021
@jameswex jameswex deleted the jupyterlab_3 branch October 12, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolga-b tolga-b tolga-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jameswex @tolga-b