Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JupyterLab 3.x and bump version number #183

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add support for JupyterLab 3.x and bump version number #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,15 +391,17 @@ Then, use it as seen at the bottom of the
[What_If_Tool_Notebook_Usage.ipynb notebook](https://colab.research.google.com/github/pair-code/what-if-tool/blob/master/What_If_Tool_Notebook_Usage.ipynb).

### How do I enable it for use in a JupyterLab or Cloud AI Platform notebook?
WIT has been tested in JupyterLab versions 1.x and 2.x.
WIT has been tested in JupyterLab versions 1.x, 2.x, and 3.x.

Install and enable WIT for JupyterLab 2.x by running a cell containing:
Install and enable WIT for JupyterLab 3.x by running a cell containing:
```
!pip install witwidget
!jupyter labextension install wit-widget
!jupyter labextension install @jupyter-widgets/jupyterlab-manager@2
!jupyter labextension install @jupyter-widgets/jupyterlab-manager
```
Note that you need to specify the correct version of jupyterlab-manager for your JupyterLab version as per https://www.npmjs.com/package/@jupyter-widgets/jupyterlab-manager.
Note that you may need to specify the correct version of jupyterlab-manager for
you JupyterLab version as per
https://www.npmjs.com/package/@jupyter-widgets/jupyterlab-manager.

Note that you may need to run `!sudo jupyter labextension ...` commands depending on your notebook setup.

Expand Down
4 changes: 2 additions & 2 deletions witwidget/notebook/jupyter/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "What-If Tool jupyter widget",
"author": "Google LLC",
"main": "dist/index.js",
"version": "1.8.0",
"version": "1.8.1",
"license" : "Apache 2.0",
"homepage": "https://github.com/pair-code/what-if-tool",
"keywords": [
Expand All @@ -26,7 +26,7 @@
"webpack": "^3.5.5"
},
"dependencies": {
"@jupyter-widgets/base": "^1.1 || ^2 || ^3"
"@jupyter-widgets/base": "^1.1 || ^2 || ^3 || ^4"
},
"jupyterlab": {
"extension": "lib/labplugin"
Expand Down
1 change: 0 additions & 1 deletion witwidget/pip_package/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
'absl-py >= 0.4',
'google-api-python-client>=1.7.8',
'ipywidgets>=7.0.0',
'jupyter>=1.0,<2',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this from a template? should we still keep >=1.0, <4 or something to denote we support up to version 3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with tolga offline, no need for this dep as witwidget is only used in the context of jupyter environments already.

'oauth2client>=4.1.3',
'six>=1.12.0',
] + _TF_REQ
Expand Down
2 changes: 1 addition & 1 deletion witwidget/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

"""Contains the version string."""

VERSION = '1.8.0'
VERSION = '1.8.1'