MAG2-244 - Changed IP proxy mode to be used everywhere when reading u… #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sers IP - Moved config dropdown to general config Changes taken from PAYONE-GmbH#450 - thanks for the contribution
|
@FatchipRobert Maybe you should cherry pick all my changes of #450 to do proper OSS, because I'm the original author of the code. |
janteuber
approved these changes
Jun 22, 2022
|
@janteuber @FatchipRobert Did you read any comments of my review at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sers IP
Changes taken from rely on proxy mode config only #450 - thanks for the contribution