Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give FormulaSemantics the input format so value() doesn't fail at load #4357

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Give FormulaSemantics the input format so value() doesn't fail at load #4357

merged 1 commit into from
Nov 6, 2018

Conversation

thpr
Copy link
Contributor

@thpr thpr commented Nov 6, 2018

No description provided.

@LegacyKing LegacyKing requested a review from a team November 6, 2018 03:28
mertonmonk
mertonmonk approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@mertonmonk mertonmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karianna karianna merged commit b1d31c2 into PCGen:master Nov 6, 2018
@thpr thpr deleted the InputFormatSemantics branch November 17, 2018 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grimreaper grimreaper grimreaper approved these changes

@mertonmonk mertonmonk mertonmonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thpr @grimreaper @mertonmonk @karianna