Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring + fix time_bnds call + add out_names tests #333

Merged
merged 64 commits into from
Apr 4, 2018
Merged

Refactoring + fix time_bnds call + add out_names tests #333

merged 64 commits into from
Apr 4, 2018

Conversation

glevava
Copy link

@glevava glevava commented Mar 30, 2018

Here is my new PR with the following changes:

  • Fix the time boudary call in a CF compliant way (see point 2 of PrePARE issues #332)
  • Add absolute value function to fill value test (see point 1 of PrePARE issues #332)
  • Add required tests on the variable name from the file when the same CMOR out_name corresponds to several CMOR entries in the corresponding table.
  • Add a "out_names_tests.json" file to easily add new cases if needed for further DR tags.
  • General refactoring simplifying code (e.g., "variable" is a now a string instead of a list, etc.)

This PR has been tested at IPSL on IPSL-CM6 production file, I haven't tested all the archive we have, I focused my tests on the files concerned by the "out_names_tests.json"
Feel free to reject the PR if the PR don't pass all your tests.

Thanks

@dnadeau4 dnadeau4 merged commit 646e2ad into PCMDI:PrePARE-fix Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants