Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove text colors and hide file progress in PrePARE #588

Merged
merged 6 commits into from
Mar 18, 2020

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Mar 17, 2020

Resolves #534
@alaniwi @sashakames

These changes add two new features to PrePARE.

  • Hide the number of files completed progress counter using the argument --hide-progress
  • Remove terminal text color codes from the output using the argument --no-text-color

This PR also includes a change that allows the output of PrePARE when running with --max-processes 1 to output to a log file when using --log.

@sashakames
Copy link
Collaborator

Hi @mauzey1 I can review in place of @sterlingbaldwin , since he doesn't work for PCMDI

@sashakames
Copy link
Collaborator

I'll need write access to the repo I guess so maybe not...

@mauzey1 mauzey1 removed the request for review from sterlingbaldwin March 17, 2020 21:08
Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauzey1 apologies for the delay on this one. We should really enable @sashakames too

@durack1
Copy link
Contributor

durack1 commented Mar 18, 2020

@gleckler1 this is another case where limited seats are causing problems, we don't have @sashakames listed on the PCMDI organization due to limited seats

@mauzey1 mauzey1 merged commit d47a211 into master Mar 18, 2020
@mauzey1 mauzey1 deleted the 534_log_friendly_prepare_output branch March 18, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in PrePARE, logfile-friendly output format
3 participants