-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to sea ice metrics #1059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clean up comments * remove ignor warnings * fix logging * rerun without warnings * change logging * time bounds edit * add plot * create fig script * fix json dims * add shebang * add import * move func to lib * update params * update dims --------- Co-authored-by: Ana Ordonez <anaordonez@comcast.net>
Review progress
|
lee1043
approved these changes
Mar 4, 2024
@acordonez thank you for the PR. I find no errors from installing the branch and running the Demo 9 notebook. It looks good to me. Please feel free to merge it. (Sorry for the delay for reviewing!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
How to test:
pytest tests/test_sea_ice.py
to run new tests orpytest tests/
to run all tests.