-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MJO xcdat conversion #1091
MJO xcdat conversion #1091
Conversation
…di_metrics into feature/1084_lee1043_MJO-xcdat
…CDAT version of the code
Progress note: The new code was able to run the demo notebook without noticeable error, but with differences in result metrics. A rigor test (run the code for all CMIP5/6 models/realizations) conducted.
Code revision:
Next step:
|
|
…requency domain to be consistent with that of cdms version
|
@acordonez I believe this PR is ready. Can you please try install code in this PR and run the demo 5 notebook to see if that works okay to you as well? |
@lee1043 Sorry for taking a few days to get to this! I ran the notebook and found no issues there. I remember you said it was expected to see some slight differences in the metrics? E.g. an east power of 0.016568144258499968 versus 0.016600374830362644? |
@acordonez thank you for reviewing. Yes, I consider that the difference you found is subtle enough to be neglected. |
This PR will resolve #1084.
Draft PR made to track changes. PR is not ready to merge until it is explicitly marked as ready.