589 ljw new metrics uw #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…di_metrics into 589_ljw_new_metrics_UW
|
@muryanto1 somehow it is still failing with circle ci, even after I merged your change. Would you mind sharing your insight on this? |
|
All test passed on circle ci except for linux_pmp_py2, linux_pmp_py3 and macos_pmp_py2, macos_pmp_py3. Following the comment of @muryanto1 at #639 (comment) I think it is okay to be merged now. |
|
@gleckler1 I am merging the MJO EWR to the master, could you please give a quick review and approve unless you see any problems? Thanks! |
|
This PR will resolve #589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MJO metrics to master. PR generated for tracking changes. NOT ready for merging until told.